This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 410973 - [DND] IEditorPart loses custom icon on detach/move
Summary: [DND] IEditorPart loses custom icon on detach/move
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-18 01:35 EDT by Norman Schoene CLA
Modified: 2015-05-06 06:25 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Norman Schoene CLA 2013-06-18 01:35:54 EDT 
Hi,

I am facing the problem that editors lose their custom icon shown in the CTabItem whenever the editor is moved (tab group, or detached).

A little more detail on the environment can be found in this forum post:
http://www.eclipse.org/forums/index.php?t=rview&goto=1064140

If any more detail is required, let me know.

Thanks,
Norman
Comment 1 Eric Moffatt CLA 2013-06-18 10:54:04 EDT 
Mark this for Luna. 

This should really be an overall review of how all the labels (and their overrides) work so that we end up with an internally consistent story. Might also want to look at the hover / disabled icon overrides as well here.
Comment 2 Eric Moffatt CLA 2013-06-21 10:04:38 EDT 
Your analysis is correct in that when we re-render the new CTabItem we do is as if the editor were just being opened. Likely the fix is to scrape the original CTI for its current values.
Comment 3 Lars Vogel CLA 2014-04-28 13:48:12 EDT 
Works for me in Build id: I20140427-2030. Marking as fixed with Luna, please reopen in case you still see this in the latest integration build of Luna.
Comment 4 Wojciech Sudol CLA 2014-06-02 07:54:02 EDT 
I can reproduce it in 4.2.2 but not in 4.4 I20140528-2000. Marking as verified.
Comment 5 Ruslan Didyk CLA 2015-05-06 05:31:13 EDT 
Please add an attachment how to fix this problem. I can not find solution. Thanks.
Comment 6 Lars Vogel CLA 2015-05-06 06:25:51 EDT 
(In reply to Ruslan Didyk from comment #5)
> Please add an attachment how to fix this problem. I can not find solution.
> Thanks.

Latest Eclipse builds can be found here: download.eclipse.org/eclipse/downloads