Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 410900 - Color preferences must be applied after each restart when using high contrast theme
Summary: Color preferences must be applied after each restart when using high contrast...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Krzysztof Kazmierczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 413621 413622 413623 413625 413659
  Show dependency tree
 
Reported: 2013-06-17 04:26 EDT by Krzysztof Kazmierczyk CLA
Modified: 2013-08-07 04:09 EDT (History)
8 users (show)

See Also:
daniel_megert: review+

Attachments
patch v1 (855 bytes, patch)
2013-06-25 10:26 EDT, Krzysztof Kazmierczyk CLA 		no flags Details | Diff
patch36-38 (934 bytes, patch)
2013-06-25 15:26 EDT, Krzysztof Kazmierczyk CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Kazmierczyk CLA 2013-06-17 04:26:38 EDT 
Steps to reproduce
Reproduced on 3.4.1 and SDK-I20130505-2000 (4.3)
1. Switch windows theme to high contrast and start Eclipse
2. Go to Windows->Preferences->Colors and change i.e. foreground color for content assist to blue
3. Use content assist -> The foreground color is blue
4. Restart Eclipse and use content assist -> The foreground color for content assist is the same as in point 1 but should be blue (as set in point 2).
Comment 1 Krzysztof Kazmierczyk CLA 2013-06-19 07:43:01 EDT 
There is a different preference saved depending on the theme. See org.eclipse.ui.internal.themes.ThemeElementHelper.createPreferenceKey(ITheme, String) (http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/internal/themes/ThemeElementHelper.java)

Probably when loading the preferences there are default loaded.
Comment 2 Krzysztof Kazmierczyk CLA 2013-06-25 10:26:51 EDT 
Created attachment 232737 [details]
patch v1

It seems that the colors were incorrectly initialized in Workbench. This simple patch resolves this issue.
Comment 3 Krzysztof Kazmierczyk CLA 2013-06-25 15:26:13 EDT 
Created attachment 232753 [details]
patch36-38

The patch from the previous comment applies to head and 4.2.2.
We need the patch to all versions since 3.6.
The patch attached here applies to version between 3.6.2 and 3.8.2.
Comment 4 Eric Moffatt CLA 2013-07-09 14:59:47 EDT 
John, I'm not sure how far back we can go...do you know ?
Comment 5 John Arthorne CLA 2013-07-10 12:59:21 EDT 
At Eclipse we only currently have one maintenance stream: 4.3.1. IBM does builds of older streams but that should be requested through IBM channels.
Comment 6 Dani Megert CLA 2013-07-23 09:10:48 EDT 
I reviewed and tested the fix - it is good for 4.4 and backports.

Krzysztof, you need to add the following statement:
This contribution complies with http://www.eclipse.org/legal/CoO.php

and clone this bug for each backport.
Comment 7 Krzysztof Kazmierczyk CLA 2013-07-24 07:52:04 EDT 
This contribution complies with http://www.eclipse.org/legal/CoO.php
Comment 9 Daniel Rolka CLA 2013-08-07 04:09:50 EDT 
Verified in the build: I20130805-2000