Community
Participate
Working Groups
4.3.0.I20130605-2000, was fine in 3.8 - open an editor - make it dirty - Window > New Editor - close duplicate dirty editor 3.8 nicely told me that the resource is still opened elsewhere and that clicking "No" in the "Save Resource" dialog will not lose changes. There's also an option for that on the General > Editors preference page: [] Prompt to save on close even if still opened elsewhere In 4.x, I just get the generic Save dialog and the preference is broken.
*** Bug 438308 has been marked as a duplicate of this bug. ***
*** Bug 355874 has been marked as a duplicate of this bug. ***
Also need to make sure the same dialog is used when indirectly closing the dirty editor by closing the window with Ctrl+W or via [x].
Wojciech, please take a look.
(In reply to Dani Megert from comment #4) > Wojciech, please take a look. If the bug regarding closing the editor (new in 4.x) and the one closing the window (already exists 3.x) have a different fix, then please attach two separate fixes.
(In reply to Markus Keller from comment #0) > In 4.x, I just get the generic Save dialog and the preference is broken. The "editor/editors opened elsewhere" dialogs do appear when the close/closeAll actions are triggered by a keyboard shortcut, so the 'core' mechanism seems to work fine.
Ping!
Fix proposition: https://git.eclipse.org/r/31819
(In reply to Wojciech Sudol from comment #8) > Fix proposition: https://git.eclipse.org/r/31819 This addresses the originally reported problem. We'll handle the scenario that involves closing the window and that is also broken in 3.x via bug 169947.
Patch with the bundle version update: https://git.eclipse.org/r/31890
(In reply to Wojciech Sudol from comment #8) > Fix proposition: https://git.eclipse.org/r/31819 This fix also fixes the prompt when using editorTab > Close All and Close Others. Submitted to master with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=7a77d4ef52685735b545074cfac6c2e61a617524
+1 for 4.4.1.
Gerrit's review link for the R4_4_maintenance branch: https://git.eclipse.org/r/31966 .
(In reply to Wojciech Sudol from comment #13) > Gerrit's review link for the R4_4_maintenance branch: > https://git.eclipse.org/r/31966 . Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=79384c9cc56d880ba39c1cf2f45369febfbe7464 Verified that the bundle versions are correct in 4.4.1.
From Wojciech: " Here is the patch for 4.3.2+ https://git.eclipse.org/r/#/c/32053/ Also here is the patch with version update (I know you mentioned to not use Gerrit for that, but this is "special" situation) - https://git.eclipse.org/r/32055 . In 4.3.2 build (packages) the versions are 3.105.2 and 0.11.2 . "
(In reply to Dani Megert from comment #15) > From Wojciech: > " > Here is the patch for 4.3.2+ https://git.eclipse.org/r/#/c/32053/ > > Also here is the patch with version update (I know you mentioned to not use > Gerrit for that, but this is "special" situation) - > https://git.eclipse.org/r/32055 . > In 4.3.2 build (packages) the versions are 3.105.2 and 0.11.2 . > " Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=01f89c32b12063048f5df32db16eaf9feaf0ef71 and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=35844c7aff7553fb704ff8b8078c4067a13875f0
Review link for the R4_2_maintenance branch : https://git.eclipse.org/r/32073 . Review link for required bundle version update in the R4_2_maintenance branch: https://git.eclipse.org/r/32086 .
(In reply to Wojciech Sudol from comment #17) > Review link for the R4_2_maintenance branch : > https://git.eclipse.org/r/32073 . > > Review link for required bundle version update in the R4_2_maintenance > branch: https://git.eclipse.org/r/32086 . Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1b0b96eb25ece91ad348e012b3fee2589b66426f and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1858fe328a514267c65540627ab22c8cd6aa226b
Verified in 4.4.1 RC3 (M20140903-1600).
Verified in 4.5 M2 candidate (I20140915-2000).
This fix has solved two other issues: bug 443263 and bug 428664.
