Community
Participate
Working Groups
This is a relatively minor temporary migration issue, but one we should fix to avoid a lot of questions from users: When a user opens a model with an existing task, they won't see any patch sets, and they won't receive any notification that they need to update becaus as far as Mylyn Task data is concerned, the model *is* up to date. So we need to check for presence of the actual file.
https://git.eclipse.org/r/#/c/13720/ <-- For comments only Actually, I'm not sure how we can easily discover this, short of adding in a model exists task data or something, and that seems to be adding a lot of complexity for little gain. So in retrospect, marking as a won't fix unless anyone has a better idea how to handle this.
I'm going to reopen this one. We probably won't be able to fix today,but I'm concerned about impact on people onboarding. What about something like just creating a Task Attribute for "Version2.0" or something and returning true for hasTaskChanged when that is false and immediatly setting it to true? And setting it to true for all new tasks? Does that make any sense?
Lily is also seeing this on master when using a clean workspace.
Discussing further w/ Sam, had the thought that we might simply store a "Model Updated" Date in Task Data. That would allow us to track whether a model actually existed at all previously and if so what it's new date is. I'm not sure if it's realistic to get this in for 2.0, but I'm going to try.
https://git.eclipse.org/r/#/c/13761/ For possible inclusion in 2.0 -- though it could be somewhat risky, the changes seem pretty innocuous and it would help a great deal with user ramp-up. Note that the issue is actually more serious than initially thought because Lily reports that she sees this in a new workspace as well, which would mean that the first time reviews are synced we aren't actually getting the hasTask changed set either.
The approach looks good to me but the patch is incomplete. I get incomings everytime I refresh the query so we'll have to refine further and take partial task data into account (and add tests). We won't be able to address this for 2.0 given the timing but we can fix it for 2.0.1. For now we'll have to suggest to users to refresh manually once. I would suggest that we add a note in the New & Noteworthy to communicate that. Miles, would it be simple to add a refresh link to the editor if it is open and we detect that the model is not cached similar to how we show that when a task has an incoming?
Should the N&N encourage users to right click the repository and select Synchronize All Tasks?
Actually, everything is working perfectly for me now that I need it to not work. ;) The thing is, the connector afaict does actually sync up all of the new reviews and creates models for them. It just takes a while to accomplish that. Once they have been upated, I *htink* everything works as expected. But I could be wrong -- still investigating.
I have updated the patch to take partial task data into account but I would still like to see a simple change for the editor that checks if the model is there and if not prompts the user to refresh. That logic won't hurt regardless of how we address the migration concern.
https://git.eclipse.org/r/#/c/13764/
I don't think we really need the Task Data at all, as this should be a migration solution only. This is actually a more general solution, because it works if for example the model directory got wiped out or moved or whatever. https://git.eclipse.org/r/#/c/13764/ wouldn't work in that case.
Steffen Merged: https://git.eclipse.org/r/#/c/13764/
I've updated to the latest master and I am not seeing a link in the task editor to refresh my reviews. The patch sets don't show up until I manually refresh or reopen the editor.
(In reply to comment #13) > I've updated to the latest master and I am not seeing a link in the task editor > to refresh my reviews. The patch sets don't show up until I manually refresh or > reopen the editor. Hmm.. works for me. Could it be because you already have an empty record there? Does this happen for totally "fresh" Reviews, that is that you have never opened before?
Not so far.
