Community
Participate
Working Groups
I had a file open using the new quick diff ruler while doing CVS update. The CVS reference provider can be found in bug 39812. !SESSION Jul 31, 2003 09:10:35.760 --------------------------------------------- java.version=1.4.1_02 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_CH Command-line arguments: -update -showlocation -data c:\eclipse\workspaces\Development_2_2\plugins -install file:C:/eclipse/drops/I20030730/ !ENTRY org.eclipse.ui.editors 4 2 Jul 31, 2003 09:10:35.760 !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.ui.editors". !STACK 0 java.util.ConcurrentModificationException at java.util.HashMap$HashIterator.nextEntry(HashMap.java:762) at java.util.HashMap$KeyIterator.next(HashMap.java:798) at org.eclipse.team.internal.ccvs.core.client.Session.internalRun(Session.java:228) at org.eclipse.team.internal.ccvs.core.client.Session.run(Session.java:158) at org.eclipse.team.internal.ccvs.core.resources.RemoteFile.getContents(RemoteFile.java:171) at org.eclipse.quickdiff.providers.CVSReferenceProvider.readDocument(CVSReferenceProvider.java:134) at org.eclipse.quickdiff.providers.CVSReferenceProvider.getReference(CVSReferenceProvider.java:59) at org.eclipse.ui.internal.editors.quickdiff.DocumentLineDiffer$1.run(DocumentLineDiffer.java:550) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:58)
We have never released the CVS quick diff support yet. I guess you are using the demo one that Kai created. Marking as dupe of bug 39812. *** This bug has been marked as a duplicate of 39812 ***
Sorry, but Session is one of the Team classes that is part of the release.
Why don't you let me triage our bugs as I see fit? I should actually of marked it invalid. And as you said, we already have another PR to implement a reference provider. When that is released you can log bugs against it. Until then, log them against the org.eclipse.quickdiff plugin.
Since when does reopening a bug have to do with triage? I did not report the bug against a not-yet existing CVS reference provider but against existing CVS code: looking at the stack trace it looks like a bug in your code. Do you argue that this piece of code currently never gets executed and hence my bug report is invalid?
I'm saying that the quickdiff plugin is calling internal CVS code and is calling it incorrectly in the first place. There was an already existing PR for us to implement a diff provider and that PR is still open. Those are my last comments. This discussion should end now, it's really not worth wasting yours or my time on. I'm going away on vacation today and will look into implementing the CVS quick diff support when I return.
