Community
Participate
Working Groups
We should add similar min/max support like e4 on SWT
retarget for 1.1.0
On how Min/Max should work: I think we actualy only need the maximize action (in regular mode), because that is usualy what a user wants: More space for a specific view for a certain amount of time. The rest of the stacks should minimize automatically. As soon as you restore the maximized stack or one of the minimzed stacks, all of them return to regular mode. So, compared to SWT, let's get rid of the minimize action. I like the possibility in SWT to active a minimized part to show its stack in a pop-up window temporarily.
New Gerrit change created: https://git.eclipse.org/r/60347
Gerrit change https://git.eclipse.org/r/60347 was merged to [master]. Commit: http://git.eclipse.org/c/efxclipse/org.eclipse.efxclipse.git/commit/?id=714d1ea42d7489d27409bce78c159ad74c54c314
I've merged the current version but I'd like you to make follow up changes: * use @Component annotations (we use https://github.com/ecliptical/ds-annotations) to generate the component.xml * Add @since 2.2.0 to the interfaces * I'm like you not a native speaker but unMaximize is certainly not english (I'll follow up on this point) * I don't think we should contribute the MaximizationServiceContextFunction through DS but through an Addon (MinMaxAddon) this allows people to turn it on/off * if there's a MaximizationService we should - maximize/minimize on double click on the TabItem - maximize/minimize on double click on the Parts TopTimArea (see WPart.SHOW_TOP_TRIM_AREA_TAG) * we should allow the user to contribute a service to veto min/max for a certain MUIElement * we should make window also a WMaximizationHost because one might develop apps without perspectives But this is a fantastic step forwards - I highly appreciate the changes!
On the names: MaximizationService#unMaximize => MaximizationService#restore MaximizationTransitionService#unMaximize => MaximizationTransitionService#restore
I made the following changes: * I renamed the unmaximize to restore * added @since * remove the contribution of the transition service - to align it it with other transitions - if a user wants animation its his responsibility to contribute a service eg by using the default one we provide More changes to come
More modifications: * I left the service and context function as is * I added a new MinMaxAddon who interacts with the model and widgets and added support for min-max when double clicking on a Tab in the MStackContainer
* and i move the maximize service and CF to the base bundle because they are not widget toolkit specific
Argh - Sun was not following this bug! Final bits implemented: * add support for applications without perspective Thanks Sun for this wonderful new feature! If we want to add min/max for none MStack-Elements we should open a new bug to track that.
New Gerrit change created: https://git.eclipse.org/r/61391
(In reply to Eclipse Genie from comment #11) > New Gerrit change created: https://git.eclipse.org/r/61391 I had some time this evening but just saw you did all the work. Cool to have all this for 2.2.0. Just added a little contribution to get rid of the context function, can you confirm this is the way to do this (creating the max. service in the minmaxaddon at widget creation time) ? Now I'm also better understanding the min max callback's purpose. Thanks a lot too, Tom !
I changed my mind and think the service is ok this way so i abandoned the change - i hope i haven't wasted much of your time!
not at all, learning is never wasted time ;)
Can I get explicit instructions on where to find and how to install the minmax addon as well as any "Tags" or "Persistent State" that might be required.
Please ask usability question at the forum - http://www.eclipse.org/forums/index.php/f/259/
