Description Martin Oberhuber 2013-05-23 16:50:40 EDT

+++ This bug was initially created as a clone of Bug #308128 +++

This change from bug 308128, which just removed the "local scope" checkbox in the Preference page where search scopes can be configured, left several open questions and obsolete code in place:

1. org.eclipse.help.ui/internal/Messages.{java|properties}
   - obsolete "LocalHelpPage_capabilityFiltering_name"

2. org.eclipse.help.internal.base.IHelpActivitySupport
   - getLocalScopeCheckboxLabel() should be marked obsolete, since unused now

3. Extension point org.eclipse.help.base.activitySupport
   - localScopeCheckbox should be marked obsolete

Point #3 is the most severe IMO, since the current *.exsd of the extension point marks the element as "required" and thus any extende who doesn't provide the element (that's actually optional and obsolete) is presented with a warning in its plugin.xml .

To reproduce, simply load the "org.eclipse.sdk" bundle from the "eclipse.platform.git" repository, and enable the PDE Nature on it. A warning is shown for the activitySupport extension.

I'm not sure what's a better approach - mark all those places obsolete / deprecated, or fix the original problem which bug 308128 apparently fixed in an incorrect way.