Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 408810 - ContributedPartRenderer log message incorrect
Summary: ContributedPartRenderer log message incorrect
Status: CLOSED DUPLICATE of bug 409746
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 08:46 EDT by Paul Webster CLA
Modified: 2013-06-03 12:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2013-05-23 08:46:45 EDT 
from org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(...).new Composite() {...}.setFocus()
String id = part.getElementId();
if (id == null) {
	logger.warn(new IllegalStateException(),
			"Blocked recursive attempt to activate part " //$NON-NLS-1$
					+ id);
} else {
	logger.warn(new IllegalStateException(),
			"Blocked recursive attempt to activate part"); //$NON-NLS-1$
}

The condition should be id != null

PW
Comment 1 Markus Keller CLA 2013-05-28 14:17:48 EDT 
Filed bug 409324 for the more severe problem that this happens at all...
Comment 2 Markus Keller CLA 2013-06-03 12:17:33 EDT 
The proposed fix for bug 409746 resolves this issue.

*** This bug has been marked as a duplicate of bug 409746 ***