Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 408554 - classic package missing product property
Summary: classic package missing product property
Status: RESOLVED DUPLICATE of bug 406985
Alias: None
Product: EPP
Classification: Technology
Component: Packager (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Linux
: P3 blocker (vote)
Target Milestone: 2.0.0 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-21 05:58 EDT by Rob Stryker CLA
Modified: 2013-05-23 16:02 EDT (History)
5 users (show)

See Also:


Attachments
Log File attached. (34.24 KB, text/x-log)
2013-05-21 05:58 EDT, Rob Stryker CLA
no flags Details
screenshot of my selected option (101.36 KB, image/png)
2013-05-21 08:06 EDT, Rob Stryker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Stryker CLA 2013-05-21 05:58:03 EDT
Created attachment 231239 [details]
Log File attached.

My steps are as follows, though I'm not sure how many of them are required for replication:

git clone  git@github.com:jbosstools/jbosstools-target-platforms.git

mvn clean install -Dmirror-target-to-repo.includeSources=true

After a long time (hours), you have an update site that I used. THe update site would be located at jbosstools-target-platforms/jbosstools/multiple/target/jbosstools-multiple.target.repo

Next, unzip a new m7 eclipse into a temporary folder. Use the standard eclipse classic m7. Help -> Install new Software, point to jbosstools-multiple.target.repo folder from previous steps. Uncheck the box showing only categorized elements, select all instead, press next. 

The wizard will see an error of some sort and attempt remediation. Finally, 3 options are shown. 

Select:  Update my installation to be compatible with the items being installed 

Press next:  see review, press next again. Accept all licenses. Press finish.  Watch as it installs all software. 

In alternate window, I have a 'watch -n 1 ls" occurring in the folder of my eclipse installation. 

File is still present when 'warning' appears in eclipse. Warning in eclipse has standard install comment: Warning, you are installing software that contains unsigned content. The auth... blah blah. 

Press OK. 

The MOMENT I press "OK", the 'eclipse' file is removed. 

Installation continues inside eclipse. Any user without the 'watch' window would not know their "eclipse" file has been removed. 

Eclipse requests a restart, asks if I would like to restart now. Click 'yes'. 

Eclipse manages to begin the restart properly, and even shows the splash screen again, but then the following shows up: 

An error has occurred. See the log file blahblahblah. 

Attaching log file. 

I am marking this as a 'blocker' even though I feel there may be a workaround (like simply unzipping the .tgz file and moving the "eclipse" file back in). Pretty sure this counts as a blocker.
Comment 1 Rob Stryker CLA 2013-05-21 05:58:48 EDT
I'll just set a hopeful target on this bug of rc1.
Comment 2 Rob Stryker CLA 2013-05-21 08:06:37 EDT
Created attachment 231246 [details]
screenshot of my selected option
Comment 3 Pascal Rapicault CLA 2013-05-21 09:59:29 EDT
Could you please give me the exact M7 download that you used? I'm suspecting that there is something wrong with it.
Comment 4 Pascal Rapicault CLA 2013-05-21 11:03:01 EDT
The package used is "eclipse-classic-kepler-M7-linux-gtk-x86_64".
The IU 'epp.package.classic' is missing the org.eclipse.equinox.p2.type.product property set to true. (<property name='org.eclipse.equinox.p2.type.product' value='true'/>)
Comment 5 Martin Oberhuber CLA 2013-05-21 11:07:09 EDT
Pascal, 

what do you think is needed to set this property ? 
Is it just supposed to be a setting in the p2.inf here:

https://git.eclipse.org/c/epp/org.eclipse.epp.packages.git/tree/packages/org.eclipse.epp.package.classic.feature/p2.inf

Can you provide a patch or instructions what we should do ?
Or would Markus know what to do ?
Comment 6 Pascal Rapicault CLA 2013-05-21 11:56:10 EDT
The following needs to be added to the various product files. This is what has been done for the platform in fix http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=6fdf5c8fe8fde36bcdd094cee4f88b4f5a4c8bf8


properties.0.name = org.eclipse.equinox.p2.type.product
properties.0.value = true


This bug is a specific case of https://bugs.eclipse.org/bugs/show_bug.cgi?id=406985
Comment 7 Martin Oberhuber CLA 2013-05-21 12:23:04 EDT
Moving to epp:packager since it looks like all packages are affected.

Markus can you take it from here ?
Comment 8 Markus Knauer CLA 2013-05-23 16:02:04 EDT
Indeed, this affects all packages, but the relevant bug 406985 has still some open issues that need to be clarified.

*** This bug has been marked as a duplicate of bug 406985 ***