This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 408359 - Breakpoints view is frequently empty when opened from minimized
Summary: Breakpoints view is frequently empty when opened from minimized
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 RC1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 435521
  Show dependency tree
 
Reported: 2013-05-17 12:54 EDT by Brian de Alwis CLA
Modified: 2014-05-22 09:52 EDT (History)
0 users

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2013-05-17 12:54:55 EDT 
Build Id: 20130516-2200

I usually minimize the breakpoints view.  I frequently find that when peeking at the view that the contents are empty.  I have to close the view and re-open the view.

(I've just seen the variable empty too, though it isn't minimized.)

There are no messages in the .log
Comment 1 Eric Moffatt CLA 2014-05-01 11:00:06 EDT 
We'll take a look in RC1...
Comment 2 Brian de Alwis CLA 2014-05-01 11:05:03 EDT 
Build-Id: 4.4.0.I20140501-0200

Repurposing this for 4.4M7: if I minimize a stack containing the breakpoints view and open as a quick-view it's now always empty.

Steps to repeat:

1. Open the Breakpoints view and drag into a separate stack
2. Minimize the stack.
3. Open the Breakpoints as a quick view.  See it's empty

If I add another view in the stack then the Breakpoints view always seems to repopulate!  In my testing yesterday, I had to switch between them first, but just the presence seems adequate this morning.
Comment 3 Eric Moffatt CLA 2014-05-01 11:11:17 EDT 
There's a fair chance that this is the result of us messing with the 'partVisible' / 'partHidden' events when you minimize stacks. We changed this to get the JUnit view to show the icon 'status' when the stack is minimized.

Likely we need to track the show / hide of a minimized stack and issue the appropriate events from the workbench. I thought there was already a tag used to indicate the 'showing' status but I can't find it now. We *should* add / remove a tag when the trim stack shows/hides, track that in the Workbench(Window?) and fire the appropriate events...

Brian, we can't do this for M7...there's gonna be some churn in fixing this so we'd best wait.
Comment 4 Paul Webster CLA 2014-05-01 11:14:16 EDT 
It's not a simple fix, and this problem is in M6, so we should look at this in RC1

PW
Comment 5 Eric Moffatt CLA 2014-05-01 14:00:31 EDT 
I've pushed a patch to Gerrit:

https://git.eclipse.org/r/25843

We likely want to clean this up a bit but we can use it to ensure that it covers the bases...
Comment 6 Eric Moffatt CLA 2014-05-09 13:38:13 EDT 
Brian, saw your comments and adjusted the code accordingly (thanks!), please take another look...
Comment 8 Eric Moffatt CLA 2014-05-16 10:10:56 EDT 
Verified in 4.4.0.I20140515-1230.