This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 408348 - Activating the minimized shared area does not activate a part in it
Summary: Activating the minimized shared area does not activate a part in it
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 413948 415004
  Show dependency tree
 
Reported: 2013-05-17 10:29 EDT by Eric Moffatt CLA
Modified: 2013-08-14 10:41 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2013-05-17 10:29:56 EDT 
Since the shared area only gets a single toolitem (and thus can't explicitly 'pick' a part to show) it should activate the most recently activated part in its area.

This may require some work on the part activation history so it can tell us the appropriate part to activate...
Comment 1 Eric Moffatt CLA 2013-07-29 16:19:00 EDT 
Committed:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cf9629c20e7bb42834c0852155226ff2dc572b4a

The code tries to identify a part to activate with the following rules:

Walk the MArea's model using each container's 'selectedElement' until it finds an MPart (or a MPlaceholder referencing an MPart). This has the desired side effect of re-activating the most recently active part in the area.

If we still don't have one then we pick the first MPart we can find (this code will likely never come into play since even the rendering sets the container's active parts).
Comment 2 Eric Moffatt CLA 2013-07-29 16:19:33 EDT 
Marking as FIXED barring feedback from tonight's build...
Comment 3 Eric Moffatt CLA 2013-07-29 16:23:24 EDT 
Marking this as fixed in master...targeted at Luna M1.
Comment 4 Eric Moffatt CLA 2013-08-07 10:57:50 EDT 
Verified in 4.4.0.I20130806-2000.
Comment 5 Eric Moffatt CLA 2013-08-14 10:40:50 EDT 
Added a small change to prevent the activation code from recursing...

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=53a177e83f86efd4b1e1ab1bd97013afa9102f75
Comment 6 Eric Moffatt CLA 2013-08-14 10:41:16 EDT 
BTW, the 4.3.1 commit already has this fix.