Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 408154 - Add option to the command constructor to allow imageClass to be appended to the element
Summary: Add option to the command constructor to allow imageClass to be appended to t...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Gabriel Luong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 407773
  Show dependency tree
 
Reported: 2013-05-15 14:02 EDT by Gabriel Luong CLA
Modified: 2013-05-16 12:00 EDT (History)
1 user (show)

See Also:
libingw: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Luong CLA 2013-05-15 14:02:17 EDT 
A command with a imageClass will create a new span node and add the imageClass to it before being appended to an element. An optional parameter should be added to the command constructor, which will allow the imageClass to be added directly to the element instead of the going through the process of creating a new span element. 

This goes back to the web accessibility tip #1.
Comment 1 Gabriel Luong CLA 2013-05-15 16:21:57 EDT 
https://github.com/gabrielluong/orion.client/tree/Bug408154
Branch: Bug408154 
commit 388b64dfb136d0ce3681bf91d847db5685343c4b
commit 4d6f33c3434b23aebcca2a5514d4b9b95c6f6c24

Add option to the command constructor to allow imageClass to be appended elements
https://github.com/gabrielluong/orion.client/commit/388b64dfb136d0ce3681bf91d847db5685343c4b

Added the go up image class directly to the button element instead of creating a <span> and fixed the styling for the go-up sprite. You will notice that adding commandSprite class will just become redundant. Hence, why it wasn't included in the first commit.
https://github.com/gabrielluong/orion.client/commit/4d6f33c3434b23aebcca2a5514d4b9b95c6f6c24

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 2 Gabriel Luong CLA 2013-05-15 16:31:58 EDT 
I should also mention the go-up button looks more consistent across Chrome and Firefox on Windows as a result of adding the image class directly to the button instead of creating a <span>.