Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 408136 - Change the wrench setting div to a button in the editor toolbar
Summary: Change the wrench setting div to a button in the editor toolbar
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Gabriel Luong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 407773
  Show dependency tree
 
Reported: 2013-05-15 10:14 EDT by Gabriel Luong CLA
Modified: 2013-05-15 15:42 EDT (History)
2 users (show)

See Also:
libingw: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Luong CLA 2013-05-15 10:14:07 EDT 
The wrench settings button is currently a div and should be changed into a button to be consistent with the rest of the buttons.
Comment 1 John Arthorne CLA 2013-05-15 10:58:47 EDT 
It's a spanner!
Comment 2 Mark Macdonald CLA 2013-05-15 11:02:34 EDT 
(In reply to comment #1)
> It's a spanner!

Maybe in the en-UK localization of Orion
Comment 3 Gabriel Luong CLA 2013-05-15 11:42:27 EDT 
https://github.com/gabrielluong/orion.client 
Branch: Bug408136
commit a0088c092b09c81fb10ae4b75354496973961b1a

The wrench button was also aligned with the rest of the buttons.

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL
Comment 4 libing wang CLA 2013-05-15 15:37:47 EDT 
looks good.