Community
Participate
Working Groups
On the search page, the sentence "You can save frequently used by searches by choosing Save Search in the search toolbar." has an extra "by", and there is no "Save Search" button. The text should be changed to: <p> You can save frequently used searches by choosing <b>Remember search as</b> in the search toolbar. </p>
Patch in https://orion.eclipse.org/git/git-commit.html#/gitapi/commit/deeafe9e269e94c16580aea86d248e87e0b4d9dc/file/carolyn/org.eclipse.orion.client/?page=1&pageSize=1 (also removed 2 dups in messages.js) The Orion review request can't find you, Libing, so I have to request a review the old-fashioned way, in bugzilla. :) https://orion.eclipse.org/git/reviewRequest.html#http://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_deeafe9e269e94c16580aea86d248e87e0b4d9dc
Created attachment 230938 [details] patch Sorry, Libing - you probably can't see the content of the commit. Here's a text patch instead, but it won't have the authoring info.
Thanks a lot, Carolyn. The changes look good.
OK, great. You'll have to commit them (sorry) because I'm not a committer. Please change the author to me before committing - thanks! Do you want to consider deleting the "You can " from the sentence so that it is a bit more declarative? (also so it would fit on one line), i.e. <p> Save frequently used searches by choosing <b>Remember search as</b> in the search toolbar. </p>
(In reply to comment #4) > OK, great. You'll have to commit them (sorry) because I'm not a committer. > Please change the author to me before committing - thanks! > > Do you want to consider deleting the "You can " from the sentence so that it > is a bit more declarative? (also so it would fit on one line), i.e. > <p> > Save frequently used searches by choosing > <b>Remember search as</b> > in the search toolbar. > </p> Committed the following authored by you, thanks. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=dcb7da1236fdeba1c5609de59e91ac0a66affea3