This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 407801 - Insertion of elements into comments should not be possible
Summary: Insertion of elements into comments should not be possible
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 1.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.1.0 M2   Edit
Assignee: Florian Thienel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-11 15:29 EDT by Carsten Hiesserich CLA
Modified: 2013-10-02 12:43 EDT (History)
0 users

See Also:

Attachments
Additional unit test for insertion of elements into comments (1.43 KB, patch)
2013-05-11 15:29 EDT, Carsten Hiesserich CLA 		no flags Details | Diff
Possible patch for insertion handling for comments (2.37 KB, patch)
2013-05-11 15:30 EDT, Carsten Hiesserich CLA 		no flags Details | Diff
Possible patch for display of valid elements in comments (804 bytes, patch)
2013-05-11 15:31 EDT, Carsten Hiesserich CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Hiesserich CLA 2013-05-11 15:29:26 EDT 
Created attachment 230816 [details]
Additional unit test for insertion of elements into comments

The VEX editor allows insertion of elements into comments. This messes up the layout and makes the document partly uneditable.

1. Place the caret in an comment
2. Document->Add->Element
3. VEX displays elements allowed for insertion to the outer Parent of the comment
4. Select an element to insert
5. Depending on the comment's position, the editor displays is totally messed

Expected:
VEX should not allow to insert child elements into comments
Comment 1 Carsten Hiesserich CLA 2013-05-11 15:30:30 EDT 
Created attachment 230817 [details]
Possible patch for insertion handling for comments
Comment 2 Carsten Hiesserich CLA 2013-05-11 15:31:13 EDT 
Created attachment 230818 [details]
Possible patch for display of valid elements in comments
Comment 3 Florian Thienel CLA 2013-05-12 04:29:38 EDT 
Carsten, thank you for this contribution. I appreciate that you also provided valuable test cases for the bug.

After a little clean-up, your contribution was accepted and incorporated with commit f726a9d02dc8a1422402e8a681153456d5139c75.
Comment 4 Carsten Hiesserich CLA 2013-06-01 03:31:44 EDT 
I assert that I:
1. authored 100% the content they are contributing
2. have the rights to donate the content to Eclipse
3. contribute the content under the EPL
Comment 5 Florian Thienel CLA 2013-10-02 12:43:57 EDT 
M2 released