This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 407536 - Some ActionSets for CDT cannot be turned off when starting enabled
Summary: Some ActionSets for CDT cannot be turned off when starting enabled
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M2   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 415520
  Show dependency tree
 
Reported: 2013-05-08 10:17 EDT by Marc Khouzam CLA
Modified: 2014-03-21 11:12 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2013-05-08 10:17:02 EDT 
CDT uses action sets to show/hide certain button/menus.  The buttons/menus no longer disappear when I turn off some of the action sets.

If I launch eclipse with the action set enabled, then turning it off does not have any impact.

If I launch eclipse with the action set disabled, then turning it on then off behaves correctly.

I am first seeing this bug in the M4 build; M3 behaves as expected.

I wasn't able to reproduce this with some other action set that I found in platform or in CDT.

To try this out:
1- install CDT :)
2- Enable action set "Reverse Debugging".  You will see a new button appear in the main tool bar with a little clock and a double arrow.
3- Close eclipse
4- Start eclipse (now the action set is pre-enabled)
5- disable the "Reverse Debugging" action set
=> the button will not disappear.

Details and screenshot about this action set can be quickly seen at:
http://wiki.eclipse.org/CDT/User/FAQ#How_do_I_do_Reverse_Debugging.3F

You can also reproduce this with the "C/C++ Tracepoints" action set:
http://wiki.eclipse.org/CDT/User/FAQ#How_can_I_trace_my_application_using_C.2FC.2B.2B_Tracepoints.3F

Please let me know if I can help figuring this out.

Thanks
Comment 1 Paul Webster CLA 2013-08-20 13:35:12 EDT 
(In reply to comment #0)
> 
> If I launch eclipse with the action set enabled, then turning it off does
> not have any impact.
> 
> If I launch eclipse with the action set disabled, then turning it on then
> off behaves correctly.
> 

I can definitely reproduce this.  In addition, if it's enabled an I can't make it disappear, if I restart then it is correctly missing.

PW
Comment 2 Paul Webster CLA 2013-08-20 14:21:50 EDT 
It effects commands added to actionSets using the activeContexts as a bridge:
 <with
       variable="activeContexts">
    <iterate
          operator="or">
       <equals
             value="org.eclipse.cdt.debug.ui.reverseDebuggingActionSet">
       </equals>
    </iterate>
 </with>

If we save the active contexts when we quit, we might be activating the context twice on the next startup ... so deactivating it once won't remove it from the activeContexts list.

Still investigating.

PW
Comment 3 Paul Webster CLA 2013-08-20 14:48:27 EDT 
We had old actionSet/context initialize code that was superceded by later actionSet work.  Just remove it.

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=de8bd0c0ef9e68298e924a12b18ca39de664e714

PW
Comment 4 Paul Elder CLA 2013-09-17 10:15:49 EDT 
Verified in 4.4 M2 (4.4.0.I20130916-2330)