Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 407505 - Maximise-Restore causes hidden editor area to be shown
Summary: Maximise-Restore causes hidden editor area to be shown
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 4.3 RC1   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-08 04:54 EDT by Steven Horsman CLA
Modified: 2013-05-17 11:01 EDT (History)
3 users (show)

See Also:
pwebster: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Horsman CLA 2013-05-08 04:54:35 EDT 
In our Eclipse-based RCP we don't always need to have an editor area, so hide it using WorkbenchPage.setEditorAreaVisible(false).

When maximise is called on a view org.eclipse.e4.ui.workbench.addons.minmax.MinMaxAddon.maximize(MUIElement) has special code for finding the editor area (Lines 645-653 in 4.2.2). Even though it is not visible it is getting added to elementsToMinimize which means is gets tagged with MINIMIZED & MINIMIZED_BY_ZOOM and therefore set to visible when restore is called.
Comment 1 Eric Moffatt CLA 2013-05-08 10:18:02 EDT 
The fix here is trivial...just check before applying the MINIMIZE & MINIMIZED_By_ZOOM tags whether the 'visible' flag is set.
Comment 2 Eric Moffatt CLA 2013-05-14 09:56:46 EDT 
Pushed a fix to Gerrit:

https://git.eclipse.org/r/12777

Only checks for min/max inside the main presentation, we can deal with 'global' stacks later since they're very rare...
Comment 4 Eric Moffatt CLA 2013-05-16 13:55:16 EDT 
Marking as FIXED...
Comment 5 Eric Moffatt CLA 2013-05-17 11:01:50 EDT 
Verified in 4.3.0.I20130516-2200.