Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 407314 - org.eclipse.platform-4.3M7.zip contains incosistent p2 repository
Summary: org.eclipse.platform-4.3M7.zip contains incosistent p2 repository
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P2 major (vote)
Target Milestone: 4.3 RC1   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 408069 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-06 12:00 EDT by Nobody - feel free to take it CLA
Modified: 2013-05-14 23:05 EDT (History)
4 users (show)

See Also:


Attachments
error message (61.27 KB, image/png)
2013-05-06 12:00 EDT, Nobody - feel free to take it CLA
no flags Details
patch to remove org.eclipse.rcp.configuration.feature.group (1.64 KB, patch)
2013-05-06 16:13 EDT, David Williams CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2013-05-06 12:00:32 EDT
Created attachment 230522 [details]
error message

The latest Platform Runtime Repo fails to install.

Steps to reproduce:
1. download org.eclipse.platform-4.3M7.zip from http://download.eclipse.org/eclipse/downloads/drops4/S-4.3M7-201305020800/

2. create a new target platform definition and add the downloaded zip as a software site
Comment 1 David Williams CLA 2013-05-06 16:05:43 EDT
This seems like its 'major' to me (lost function).
Comment 2 David Williams CLA 2013-05-06 16:13:11 EDT
Created attachment 230548 [details]
patch to remove org.eclipse.rcp.configuration.feature.group

This patch contains two fixes, one for this bug ... to remove 
org.eclipse.rcp.configuration.feature.group since we no longer have one of those, 

and also a more straightforward fix for bug 405808.
Comment 3 David Williams CLA 2013-05-06 16:15:34 EDT
I'm actually not sure removing 
org.eclipse.rcp.configuration.feature.group
will fix this bug entirely .... but, seems like the first thing to try, and would be required anyway, even if other steps needed.
Comment 4 David Williams CLA 2013-05-06 16:16:19 EDT
Paul, any comments? Insights?
Comment 5 David Williams CLA 2013-05-06 16:37:01 EDT
For some history, of when/how we got rid of org.eclipse.rcp.configuration as a feature, see bug 401037. 

I didn't know it was list in this "custom script".
Comment 6 David Williams CLA 2013-05-06 16:40:57 EDT
This commit will remove the feature from the explicit list ... 
not sure this completely accounts for error message, but is worth removing features that no longer exist as features in out repo. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=6ca0d4ab5db89f2a1e0323f5ed9355044738a837
Comment 7 David Williams CLA 2013-05-06 19:54:01 EDT
(In reply to comment #6)
> This commit will remove the feature from the explicit list ... 
> not sure this completely accounts for error message, but is worth removing
> features that no longer exist as features in out repo. 
> 
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=6ca0d4ab5db89f2a1e0323f5ed9355044738a837

I've reverted this change. From looking at old PDE builds, I've convinced myself it is supposed to be in the repo ... so, the question will be how to get it back in.
Comment 8 David Williams CLA 2013-05-06 19:56:42 EDT
reopening till proper fix is known.
Comment 9 David Williams CLA 2013-05-07 19:18:54 EDT
Today's build looks better,

http://download.eclipse.org/eclipse/downloads/drops4/I20130507-1100/

but if I check "configuration" still says missing "configuration feature jar" (which is a "noop" feature we were/are trying to "get rid of", but may not be able to, entirely). 

I assume when you use the target this way, you unselect "categories" and pick everything in the list?
Comment 10 Nobody - feel free to take it CLA 2013-05-08 08:05:55 EDT
In fact we are using this zip in our PDE build, where the "p2.repo2runnable" ant task fails because the p2 repository is not valid.

Trying to set it as target platform like described here seems to be just another occurrence of the same problem.
Comment 11 David Williams CLA 2013-05-08 08:40:57 EDT
(In reply to comment #10)
> In fact we are using this zip in our PDE build, where the "p2.repo2runnable"
> ant task fails because the p2 repository is not valid.
> 
> Trying to set it as target platform like described here seems to be just
> another occurrence of the same problem.

Ah, in that case, can you try a more recent build ... such as ... 
http://download.eclipse.org/eclipse/downloads/drops4/I20130507-1100/ 

It may work well enough to perform p2.repo2runnable. 

There may be more changes ... but would appreciate as much early testing as you can do. Thanks.
Comment 12 David Williams CLA 2013-05-09 00:42:37 EDT
I've added what I think is the last piece of this puzzle ... not very pretty ... but I think necessary. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=c1d7dee5f426a6b9424421ee38b538c406c342ba

I'm slipping in now so I can do a test build before the next I-build on Thursday.
Comment 13 David Williams CLA 2013-05-09 08:25:41 EDT
(In reply to comment #12)
> I've added what I think is the last piece of this puzzle ... not very pretty
> ... but I think necessary. 
> 
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=c1d7dee5f426a6b9424421ee38b538c406c342ba
> 
> I'm slipping in now so I can do a test build before the next I-build on
> Thursday.

I'd missed a closing tag in above commit, which I document here in case I need to revert. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=1fcda711a356a550c2c11f8a88ea2804c5a099c1

Plus, in test build, the strategy failed since there is no /repository created by rcp.config. Not sure why it has always been "packaged" as a feature, instead of a repository, like all the other elements of that section. So, one more test build, producing a repository ... and if that doesn't work, will back all out. 

http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/commit/?id=e420938131f5dfbafd85f087f7613b644f7b7311
Comment 14 David Williams CLA 2013-05-09 08:50:00 EDT
(In reply to comment #13)
> (In reply to comment #12)
> > I've added what I think is the last piece of this puzzle ... not very pretty
> > ... but I think necessary. 
> > 
> > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> > commit/?id=c1d7dee5f426a6b9424421ee38b538c406c342ba
> > 
> > I'm slipping in now so I can do a test build before the next I-build on
> > Thursday.
> 
> I'd missed a closing tag in above commit, which I document here in case I
> need to revert. 
> 
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=1fcda711a356a550c2c11f8a88ea2804c5a099c1
> 
> Plus, in test build, the strategy failed since there is no /repository
> created by rcp.config. Not sure why it has always been "packaged" as a
> feature, instead of a repository, like all the other elements of that
> section. So, one more test build, producing a repository ... and if that
> doesn't work, will back all out. 
> 
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=e420938131f5dfbafd85f087f7613b644f7b7311

This failed right away, in "pom updater" ... "not able to find o.e.rcp.config.feature.group ... " ... I obviously need to do more to go this route ... but .. seems it must be the wrong approach if its too hard. :) 
 
So, reverted all related changes.
Comment 15 Nobody - feel free to take it CLA 2013-05-10 06:26:15 EDT
I20130507-1100 works fine!


(In reply to comment #11)
> (In reply to comment #10)
> > In fact we are using this zip in our PDE build, where the "p2.repo2runnable"
> > ant task fails because the p2 repository is not valid.
> > 
> > Trying to set it as target platform like described here seems to be just
> > another occurrence of the same problem.
> 
> Ah, in that case, can you try a more recent build ... such as ... 
> http://download.eclipse.org/eclipse/downloads/drops4/I20130507-1100/ 
> 
> It may work well enough to perform p2.repo2runnable. 
> 
> There may be more changes ... but would appreciate as much early testing as
> you can do. Thanks.
Comment 16 David Williams CLA 2013-05-12 16:49:33 EDT
(In reply to comment #15)
> I20130507-1100 works fine!
> 

That's good to hear! But, as a "runtime target", it did still look odd if someone selected the "configuration feature" then the UI would complain it was not valid, since there was no "configuration jar". For other reasons, we are going to leave in that "empty jar", so will close this as fixed, once I confirm. (See bug 401037 and bug 407703 for reference).
Comment 17 David Williams CLA 2013-05-12 18:23:50 EDT
Test builds seem to work fine, with no "errors" using it as a PDE target. 

Can be tested/verified in build => I201305122000 (i.e. beginning Monday 5/13).
Comment 18 David Williams CLA 2013-05-14 23:05:56 EDT
*** Bug 408069 has been marked as a duplicate of this bug. ***