Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 407209 - Orionode Minified builds have "blank page syndrome" and Missing paths to build shellpage
Summary: Orionode Minified builds have "blank page syndrome" and Missing paths to buil...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Gabriel Luong CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-03 17:03 EDT by Gabriel Luong CLA
Modified: 2013-05-29 16:38 EDT (History)
2 users (show)

See Also:
gabriel.luong: review?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Luong CLA 2013-05-03 17:03:07 EDT
The minified pages for orionode do not load. Some of the required sources are missing such as css, and plugins. This is related to Bug 404957. 

To reproduce the symptom:
1. Clone the latest orion.client
2. npm install
3. Run build.js to minify
4. Start orionode
5. Page is blank

Running the build.js script the errors that were noted are the following:
Tracing dependencies for: shell/shellPage
Error: ENOENT, no such file or directory 'c:\Users\IBM_ADMIN\Project\orion.client\modules\orionode\build\.temp\gcli\index.js'
In module tree:
    shell/shellPage
      orion/shell/Shell

Error: ENOENT, no such file or directory 'c:\Users\IBM_ADMIN\Project\orion.client\modules\orionode\build\.temp\gcli\index.js'
In module tree:
    shell/shellPage
      orion/shell/Shell

    at Object.fs.openSync (fs.js:427:18)


Mark noted that orion.build.json needs to be updated.
Comment 1 Gabriel Luong CLA 2013-05-06 12:35:13 EDT
https://github.com/gabrielluong/orion.client 
Branch: Bug407209
commit 697c7db5b463f1cca32f61b3b5fbc9827c8dfec8

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL

The problem was best summarized in [3] in https://bugs.eclipse.org/bugs/show_bug.cgi?id=404957.

To reiterate Mark's description of the problem, RequireJS will load the js file (built-{name}.js) specified in the html files ({name}.html):
> <script>
>   require({
>     /* .. */
>   });
> 
>   require(["built-{name}.js"]); // !!
> </script>
but will not do anything afterwards since there is no module named built-{name}.js to call upon in the built-{name} js files. Instead we had define("{pageDir}/{name}":
> define("navigate/table"

The fix was to update the built js files and perform a replace on define("{pageDir}/{name}" with define("built-{name}.js".
Comment 2 Gabriel Luong CLA 2013-05-06 13:31:32 EDT
https://github.com/gabrielluong/orion.client 
Branch: Bug407209
commit 4d613f765f874101edf2a3c52e3055b2c47f0b91
https://github.com/gabrielluong/orion.client/commit/4d613f765f874101edf2a3c52e3055b2c47f0b91

Also added the missing paths to orion.build.json to get shellPage to build correctly.

I assert that I authored 100% of the content of this contribution and have the rights to donate the content to Eclipse under the EPL