Community
Participate
Working Groups
The summary says it all.
This got broken since we started the CBI builds. The problem happens because the s390/s390x executables are in the contributed folder (not bin) in the rt.equinox.binaries repo. And the pom.xml file is not copying them over. Fixed http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=498bb737b868b67c06a8affc278676200a39ada3
We need to touch the bundle since the fix was just in a pom.xml file. http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=1af6d94de996c73f90d2f09829725c0ea0e9db0b
The s390/s390x launchers are still missing in I20130507-1100.
The <eclipse_dir>/about_files folder and about.html file are also missing. Thanh, would you happen to know how the equivalent files for other platforms are included in the CBI build? I believe in the p2 build they would be included in: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/tree/bundles/org.eclipse.equinox.executable/target.build.xml
(In reply to comment #4) > The <eclipse_dir>/about_files folder and about.html file are also missing. I'm not sure I understand what your looking at? I ran a local build for the s390x and I can see about.html in the produced jar. I think I misunderstood though. Archive: org.eclipse.equinox.launcher.gtk.linux.s390x-1.1.200-SNAPSHOT.jar creating: META-INF/ inflating: META-INF/MANIFEST.MF inflating: launcher.gtk.linux.s390x.properties inflating: eclipse_1504.so inflating: about.html creating: META-INF/maven/ creating: META-INF/maven/org.eclipse.equinox/ creating: META-INF/maven/org.eclipse.equinox/org.eclipse.equinox.launcher.gtk.linux.s390x/ inflating: META-INF/maven/org.eclipse.equinox/org.eclipse.equinox.launcher.gtk.linux.s390x/pom.xml inflating: META-INF/maven/org.eclipse.equinox/org.eclipse.equinox.launcher.gtk.linux.s390x/pom.properties
The missing files are in the root of the eclipse install (not in the launcher plugin). See below the contents of the root in 4.3M6 and 4.3M7. [test@ssqfd18vh eclipse]$ pwd /home/test/Downloads/43m6/eclipse [test@ssqfd18vh eclipse]$ ls -al total 312 drwxrwxr-x. 9 test test 4096 Mar 14 16:19 . drwxrwxr-x. 3 test test 4096 May 8 10:40 .. drwxrwxr-x. 2 test test 4096 May 8 10:40 about_files (MISSING) -rw-rw-r--. 1 test test 11383 Mar 14 15:50 about.html (MISSING) -rw-rw-r--. 1 test test 107578 Mar 14 16:19 artifacts.xml drwxrwxr-x. 5 test test 4096 May 8 10:40 configuration drwxrwxr-x. 2 test test 4096 Mar 14 16:19 dropins -rwxr-xr-x. 1 test test 79482 Feb 26 22:07 eclipse (MISSING) -rw-rw-r--. 1 test test 288 Mar 14 16:19 eclipse.ini -rw-rw-r--. 1 test test 60 Feb 26 22:03 .eclipseproduct -rw-rw-r--. 1 test test 16536 Feb 26 22:03 epl-v10.html drwxrwxr-x. 28 test test 4096 Mar 14 16:19 features -rw-rw-r--. 1 test test 9230 Feb 26 22:03 notice.html drwxrwxr-x. 4 test test 4096 Mar 14 16:19 p2 drwxrwxr-x. 11 test test 40960 May 8 10:40 plugins drwxrwxr-x. 2 test test 4096 May 8 10:40 readme [test@ssqfd18vh eclipse]$ pwd /home/test/Downloads/43m7/eclipse [test@ssqfd18vh eclipse]$ ls -al total 224 drwxrwxr-x. 8 test test 4096 May 7 13:30 . drwxrwxr-x. 3 test test 4096 May 7 15:21 .. -rw-rw-r--. 1 test test 107215 May 7 13:30 artifacts.xml drwxrwxr-x. 5 test test 4096 May 7 15:21 configuration drwxrwxr-x. 2 test test 4096 May 7 13:30 dropins -rw-rw-r--. 1 test test 312 May 7 13:30 eclipse.ini -rw-rw-r--. 1 test test 60 Apr 19 17:55 .eclipseproduct -rw-rw-r--. 1 test test 16536 Apr 19 17:55 epl-v10.html drwxrwxr-x. 27 test test 4096 May 7 13:30 features -rw-rw-r--. 1 test test 9230 Apr 19 17:55 notice.html drwxrwxr-x. 4 test test 4096 May 7 13:30 p2 drwxrwxr-x. 11 test test 49152 May 7 15:21 plugins drwxrwxr-x. 2 test test 4096 May 7 15:21 readme
Hmm, I had thought the sdk product got it's launchers from the -root.zip files produced in rcp.config. For example when I look at: org.eclipse.rcp.configuration_root.gtk.linux.s390x-1.0.0.v20130423-1723-root.zip I can see it has the missing files. But when I look at the SDK product for s390x it's missing those files. If I look at one of the other products like the one for linux.gtk.x86 I can see it has the binary "eclipse" file but it's also missing the "about_files" and "about.html". So I'm not sure where it's pulling those files now...
Looking at sdk/target/repository/binary I noticed there are no executable binary bundles built for s390 and s390x. For example Linux x86_64 I see a bundle like this: org.eclipse.sdk.ide.executable.gtk.linux.x86_64_4.3.0.I20130508-1517
Looking in org.eclipse.equinox.executable.feature I noticed the s390x zip org.eclipse.equinox.executable_root.gtk.linux.s390x-3.6.0.v20130423-2107-root.zip is also missing the executable. The Linux root zips have a "launcher" binary but not for the s390x.
Created attachment 230681 [details] contributed.patch Attached patch is necessary to copy the contributed launchers over to org.eclipse.equinox.executable.feature. Unfortunately it doesn't solve the issue of launchers missing. The launchers now are copied over to the feature's contributed folder but it's still missing the the /target/*-root.zip files. I'm not sure why it's not being updated.
I have committed your patch and also touched the forceQualifierUpdate.txt file as this change is in a pom.xml file. I want to check the next build. http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=6214b75ac565d2c9436b1a988361caa54f1564e8
(In reply to comment #11) > I have committed your patch and also touched the forceQualifierUpdate.txt > file as this change is in a pom.xml file. I want to check the next build. > I just realized the forceQualifierUpdate.txt actually needs to be committed for this to work. I was working on it in my staging area. After committing it in git and running a new build the launcher finally appeared in org.eclipse.equinox.executable.feature's *-root.zip files. Hopefully this means they will appear in the SDK product in the next build.
(In reply to comment #12) > Hopefully this means they will appear in the SDK product in the next build. I checked the build this morning and looks like the executable is still missing from the final SDK eclipse-SDK-I20130508-2000-linux-gtk-s390x.tar.gz
Looking through my own logs I noticed the SDK product is picking up a version of the root files I didn't build: org.eclipse.rcp.configuration_root.gtk.linux.s390x/1.0.0.v20130423-1723 I would have expected this to be a bundle with yesterday's date so I suspect the reason it's still missing is it's not picking up the newer bundle.
(In reply to comment #14) > Looking through my own logs I noticed the SDK product is picking up a > version of the root files I didn't build: > > org.eclipse.rcp.configuration_root.gtk.linux.s390x/1.0.0.v20130423-1723 > > I would have expected this to be a bundle with yesterday's date so I suspect > the reason it's still missing is it's not picking up the newer bundle. Whoops that's for rcp.configuration. The one for org.eclipse.equinox.executable seems correct: org.eclipse.equinox.executable_root.gtk.linux.s390x/3.6.0.v20130508-2350
For completeness this is the list of bundles with s390x my build is picking up. org.eclipse.swt.gtk.linux.s390x/3.102.0.v20130501-2152 org.eclipse.equinox.launcher.gtk.linux.s390x/1.1.200.v20130327-1440 org.eclipse.equinox.executable_root.gtk.linux.s390x/3.6.0.v20130508-2350 org.eclipse.rcp.configuration_root.gtk.linux.s390x/1.0.0.v20130423-1723
Something else I noticed. In the SDK's produced repository: /eclipse.platform.releng.tychoeclipsebuilder/sdk/target/repository/binary there is no org.eclipse.sdk.ide.executable for the s390 and s390x: $ ls org.eclipse.cvs_root_1.4.0.v20130508-1308 org.eclipse.jdt_root_3.9.0.v20130508-1308 org.eclipse.platform_root_4.3.0.v20130508-1308 org.eclipse.rcp_root_4.3.0.v20130508-1308 org.eclipse.sdk.ide.executable.cocoa.macosx.x86_4.3.0.I20130509-1018 org.eclipse.sdk.ide.executable.cocoa.macosx.x86_64_4.3.0.I20130509-1018 org.eclipse.sdk.ide.executable.gtk.linux.x86_4.3.0.I20130509-1018 org.eclipse.sdk.ide.executable.gtk.linux.x86_64_4.3.0.I20130509-1018 org.eclipse.sdk.ide.executable.win32.win32.x86_4.3.0.I20130509-1018 org.eclipse.sdk.ide.executable.win32.win32.x86_64_4.3.0.I20130509-1018
This is likely related to bug 394216. I notice that in M6, the executable was there (I checked the platform binary distribution) and not there in M7. In particular, I assume you are aware of the patch in bug 394216 comment 45. I ask because, in addition to all the confusion I have in that bug, I notice in our git repo, there is rt.equinox.binaries/org.eclipse.equinox.executable/contributed but also rt.equinox.framework/bundles/org.eclipse.equinox.executable/contributed and now rt.equinox.framework/features/org.eclipse.equinox.executable.feature/contributed Your s390x stuff is in the first, and I assume that's still correct? ... but ... it is confusing. Tom, or Paul, can you confirm that the "executables" in rt.equinox.framework is no longer used? The one in 'bundles' I mean. But during our build, we still get "final product" from rt.equinox.binaries? Or is a simple fix there that the 'contributed' folder in the new 'features/org.eclipse.equinox.executable.feature need to be brought up to date?
Should be fixed in tonight's (5/12) I build, with work done in bug 407703 and reverting bug 401037. BUT, be sure I am "getting" the right one. I am "getting" it from rt.equinox.binaries/org.eclipse.equinox.executable/contributed/gtk/linux/s390 and rt.equinox.binaries/org.eclipse.equinox.executable/contributed/gtk/linux/s390x And from some other bugs, it's hard to tell in all the equinox stuff, which is "current" and which is "out of date".
