Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 406942 - BrandingIron#modifyInfoPListFile(..) should not remove icon
Summary: BrandingIron#modifyInfoPListFile(..) should not remove icon
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.9.0 Kepler   Edit
Hardware: PC Mac OS X
: P3 major (vote)
Target Milestone: Kepler RC1   Edit
Assignee: Ian Bull CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 402051
  Show dependency tree
 
Reported: 2013-04-30 14:28 EDT by Markus Keller CLA
Modified: 2013-05-16 16:06 EDT (History)
4 users (show)

See Also:
pascal.rapicault: review+

Attachments
Fix (1.00 KB, patch)
2013-04-30 14:28 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-04-30 14:28:46 EDT 
Created attachment 230318 [details]
Fix

I don't know what exactly causes bug 402051, but we can't ship like that.

The code in BrandingIron#modifyInfoPListFile(..) that removes the icon name if no new name could be found doesn't make sense. In #copyMacIni(..), you already do a check "if (iconName.length() > 0)", so #modifyInfoPListFile(..) should do the same.

Maybe that's already enough to fix bug 402051.
Comment 1 Ian Bull CLA 2013-05-16 16:05:42 EDT 
To hopefully get this into Tycho for Kepler I've released this.

http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=6632465a3e69d810e75a13e41a6000a3bcd41234

Pascal has reviewed.
Comment 2 Ian Bull CLA 2013-05-16 16:06:21 EDT 
.