Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 406756 - we don't need a master-ecf feature
Summary: we don't need a master-ecf feature
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.3 M7   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-28 21:36 EDT by David Williams CLA
Modified: 2013-05-30 16:44 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2013-04-28 21:36:33 EDT
This is used, as the master-jetty feature was used (see bug 406746), to put things into the final repository ... but ... everything it puts there, is already included elsewhere. 

You can tell, included elsewhere, since everything listed in master-ecf feature is already included in eclipse.sdk distribution. 

There are some exceptions.  

It includes org.apache.commons.httpclient and org.apache.commons.httpclient.source 
But those are even no longer used any longer in Eclipse ... instead 
org.apache.httpcomponents.httpclient, 4.x being used. (And, it, and its source, is included in eclipse.sdk (and p2 features). 

It would be good to get rid of this master feature ... even if it takes a while to git ride of all the master features, it'd be progress to remove the obvious ones, that should take no further adjustment.
Comment 2 David Williams CLA 2013-04-29 01:59:12 EDT
A test build of this change failed, but seemed unrelated to this change, per se, but instead to the way qualifiers are computed, combined with the fact that we remove some .... so, I'm going to try and "touch" master-equinox, and see if that alone fixes the problems. The error message was: 

[ERROR] Failed to execute goal org.eclipse.tycho:tycho-p2-publisher-plugin:0.17.0:publish-products (default-publish-products) on project eclipse.platform.repository: Execution default-publish-products of goal org.eclipse.tycho:tycho-p2-publisher-plugin:0.17.0:publish-products failed: "No solution found because the problem is unsatisfiable.": ["Unable to satisfy dependency from master.feature.group 3.4.0.v20130429-0209 to master-equinox.feature.group [1.1.0.v20130428-0418]."
Comment 3 David Williams CLA 2013-04-29 06:15:03 EDT
(In reply to comment #2)
> A test build of this change failed, but seemed unrelated to this change, per
> se, but instead to the way qualifiers are computed, combined with the fact
> that we remove some .... so, I'm going to try and "touch" master-equinox,
> and see if that alone fixes the problems. 

Test build with this 'touch' went fine. 

Besides 'master' (which, we do have to keep, at least for one case I know of, we are left with 'master-equinox and master-equinox-weaving ... we could likely "move" their contents into 'master' (at a minimum) to avoid much of the "invalid delete" operations.
Comment 4 David Williams CLA 2013-05-30 16:44:55 EDT
mass change to 'verified', as these bugs are either routine or obviously fixed build breaks.