Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 406478 - [implementation][content assist] Use enhanced for loop for CompletionProposalCollector and CompletionProposalCategory
Summary: [implementation][content assist] Use enhanced for loop for CompletionProposal...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.3 M7   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-24 14:14 EDT by Lars Vogel CLA
Modified: 2013-04-25 05:28 EDT (History)
2 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2013-04-24 14:18 EDT, Lars Vogel CLA 		no flags Details | Diff
Update Patch (9.21 KB, patch)
2013-04-24 15:07 EDT, Lars Vogel CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2013-04-24 14:14:51 EDT 
I suggest to use the foreach loop in ContentAssistProcessor. Patch to follow soon.
Comment 1 Lars Vogel CLA 2013-04-24 14:18:54 EDT 
Created attachment 230083 [details]
Patch

Attached a patch for the suggested change. I tried to create a Gerrit review, but I think JDT did not yet setup Gerrit. Please correct me if I'm wrong, maybe my setup is wrong for JDT.
Comment 2 Lars Vogel CLA 2013-04-24 15:07:06 EDT 
Created attachment 230089 [details]
Update Patch

Updated Patch also changes CompletionProposalCategory
Comment 3 Dani Megert CLA 2013-04-25 05:28:44 EDT 
Thanks for the patch. Updated copyright date and then committed as http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=2d5bd8929f145ed59de22ea994964a0089c817e3