Comment 1 Sarika Sinha 2013-04-23 02:02:05 EDT

We have moved from eclipse 3.6 to eclipse 4.2.2.
And now we are seeing a problem with Save All action.
After we do a change in the editor and click on "Save All" ( or use Ctrl Shift S)
Editor file is saved but Save All button is not disabled.
When we click it next time, it is disabled.

After debugging I saw that after first Save All,follwin editor remains dirty :

org.eclipse.e4.ui.model.application.ui.basic.impl.PartImpl@d81616fe (elementId: org.eclipse.ui.navigator.ProjectExplorer, tags: [View, categoryTag:General], contributorURI: null) (widget: ContributedPartRenderer$2 {}, renderer: org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer@7a7c6006, toBeRendered: true, onTop: false, visible: true, containerData: null, accessibilityPhrase: null) (contributionURI: bundleclass://org.eclipse.ui.workbench/org.eclipse.ui.internal.e4.compatibility.CompatibilityView, object: org.eclipse.ui.internal.e4.compatibility.CompatibilityView@a3b58e03, context: PartImpl (org.eclipse.ui.navigator.ProjectExplorer) Context, variables: [], label: Project Explorer, iconURI: platform:/plugin/org.eclipse.ui.navigator.resources/icons/full/eview16/resource_persp.gif, tooltip: Workspace, dirty: true, closeable: true, description: null)

Comment 2 Dani Megert 2013-04-23 04:11:31 EDT

I cannot reproduce this in the Eclipse SDK R4.2.2 and 4.3 M6. If you can, please provide more detailed steps.

I suspect it is related to a model being shown in the 'Project Explorer'. Can you try this:
1. close the 'Project Explorer'
2. open the file
3. save all
==> is the menu now disabled?


Reducing severity: that 'Save All' is enabled is not nice but it does not harm.

Comment 3 Sarika Sinha 2013-04-23 05:43:37 EDT

Hi,
So I tried out few things:
1. I closed the PE , changed the file in my editor. Save all is disabled after one click.
2. I opened the file , did some change in my file. Closed PE, it prompted me to Save I said Yes. After that "Save All" is never disabled(how many ever times I click it). I opened PE again and "Save All" is disabled on its own.

Comment 4 Dani Megert 2013-04-23 05:53:12 EDT

Could be related to bug 406000.

Comment 5 Dani Megert 2013-04-23 05:53:33 EDT

(In reply to comment #4)
> Could be related to bug 406000.

Bug 406275 that is.

Comment 6 Dani Megert 2013-04-23 05:54:39 EDT

(In reply to comment #5)
> (In reply to comment #4)
> > Could be related to bug 406000.
> 
> Bug 406275 that is.

Forget this comment, wrong bug.

Comment 7 Abhishek Kishore 2013-04-23 06:06:58 EDT

(In reply to comment #4)
> Could be related to bug 406000.

This could be related to Bug 405562

Comment 8 Daniel Rolka 2013-06-10 08:01:12 EDT

The issue is still present in the build 4.3RC4. It can be reproduced using the steps:

1) Open some file in editor (It does not matter if the PE is opened or not)
2) Do some change in the file
3) Close the editor. The save confirmation dialog will be displayed. 
4) Press 'no' button to lost changes. The save button is disable, but the 'save all' is enabled. When 'yes' button is selected in the confirmation dialog it works fine

I will investigate it

Daniel

Comment 9 Paul Webster 2013-06-20 09:43:40 EDT

Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=92414611ce10ef5713ba2ef1ec890a7838229ee7

Thanks Daniel.

PW

Comment 10 Daniel Rolka 2013-08-07 03:31:05 EDT

Verified in the build: I20130805-2000