Community
Participate
Working Groups
The <property name="addToEarByDefault" value="true"/> doesn't have any effect in JPA project wizard. The JPA Project wizard should honor the property there or provide an alternative property to override the default configuration, so adopters may establish the required behavior
Please investigate.
Hi - any update on this? This affects our adoption of Kepler...
Where is this property set?
We're happy to try and resolve this issue, but seems to feel like a new requirement (or at least something we weren't aware that was supposed to be supported). Did something change and we have regressed somehow, or is this a new issue?
(In reply to comment #4) > We're happy to try and resolve this issue, but seems to feel like a new > requirement (or at least something we weren't aware that was supposed to be > supported). Did something change and we have regressed somehow, or is this > a new issue? Related with this is the https://bugs.eclipse.org/bugs/show_bug.cgi?id=234383, before of that JPA was by default added to an EAR, after the fix it was not the "default" any more. Anyway, there are still users that consider the previous behavior as the default one, specially in the JEE context; so, the best thing to do is a mechanism that allows the adopters to define the default value for the "Add to EAR", so it won't impact any kind of users, it can a new configuration value, but it is important to highlight that the behavior was modified.
This is actually pretty hairy due to the ... particular nature of data model wizards. I've tried to alter the facets selected based on the product preference, but the wizard keeps undoing what my default values should be (as I've noticed it doing in other places) so I don't think that this is a good way to solve this problem. It gets very messy very quickly. The better (and possibly only) ways to solve the problem all add something that wasn't there before: 1 - Add a second JPA project wizard so that we'd have one wizard that would create SE projects and one that would create EE projects, and they'd have different fixed facets. The JPA EE project wizard would respect the boolean, the SE would not. 2 - Create a dynamic "Default JPA Configuration" preset that would optionally include the utility facet if the product preference were set. This would be the initial preset selected for the wizard, and the user would have to select the "Default Configuration" to remove the utility facet (and the add to ear option). I'm not sure that this is strictly possible. 3 - Create two presets "Default JPA Configuration" and "Default JPA EE Configuration", which one is preselected would depend on the product preference, and one could switch between them, with the product preference being respected for the EE config. Thoughts?
Hi Paul, amongst your choices, I would vote for #2 first, then #3. I think we we should avoid #1 and multiple wizards if at all possible. We are ok with waiting for SR1 for a proper fix so there's no urgent need for this to make RC1.
Created attachment 231171 [details] proposed patch Here's a proposal. I've created two dynamic preset configurations: Basic JPA and Basic JPA EE. (I tried using one dynamic preset configuration, but it was very flaky, and presented weird usage behavior.) If the default is to "add to ear" the EE preset is used initially. If not, the "SE" (sometimes not actually SE) preset is used initially. These presets don't appear anywhere other than the JPA project wizard. I like the flow of this. Screenshots following.
Created attachment 231172 [details] screenshot1 This screenshot shows the initial dialog for the case where the default is not to add to ear. It also shows the description for the two presets.
Created attachment 231173 [details] screenshot2 This screenshot shows the initial dialog for default add-to-ear = true.
We'd like to avoid making this change in a service release, so given Paul's recent proposal, are there any objections to the proposed change for Kepler RC2?
Leonard, Julio, Chuck? We've gotten OK on our end. Does this sound OK on yours?
(In reply to comment #12) > Leonard, Julio, Chuck? > > We've gotten OK on our end. Does this sound OK on yours? Sounds good to me
Sounds good - submit to PMC!
It is fine for me too.
Created attachment 231415 [details] different patch only sets to JPA preset on wizard initially
After much testing today, I think the most recent patch does the best job without being too intrusive to the existing behavior. The second patch also addresses some issues with Add to EAR functionality.
Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. This addresses an issue in an adopter product where previous functionality no longer existed. Is there a work-around? If so, why do you believe the work-around is insufficient? No workaround. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Fix has been manually tested by Paul and myself. Give a brief technical overview. Who has reviewed this fix? See comment 8 and comment 16. I have reviewed the fix. What is the risk associated with this fix? Risk is medium. Changes have been tested, but as this is project creation code there is some risk involved.
Approved - thanks for submitting this solution, I think this is an improvement all around...
Changes pushed to master for RC2.
