Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 406232 - Quick fix to add require bundle for missing class does not check if that class is visible
Summary: Quick fix to add require bundle for missing class does not check if that clas...
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 4.3 M7   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 11:59 EDT by Curtis Windatt CLA
Modified: 2013-04-29 11:03 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2013-04-22 11:59:17 EDT 
1) Find a package default class
org.eclipse.ui.internal.quickaccess.QuickAccessEntry
2) Create a class in a different bundle and attempt to use that class
List<QuickAccessEntry> list;
3) Look at the quick fixes
a) Add 'org.eclipse.ui.workbench' to required bundles
 - Fails to fix the problem because the class isn't visible, quickfix stays and will allow another entry to be added to the manifest
b) Import 'QuickAccessEntry'
 - Leads to another problem marker for the import that isn't visible
Comment 1 Curtis Windatt CLA 2013-04-23 11:23:13 EDT 
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=8a995036b04c87f19146f6760784224a947f29f0

Fixed in master along with Bug 378319 and Bug 406217.
The search engine now considers whether the class is public.
Comment 2 Curtis Windatt CLA 2013-04-29 11:03:25 EDT 
Verified in I20130428-2000