406035 – Can't submit review

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 406035 - Can't submit review

Summary: Can't submit review

Status:	RESOLVED DUPLICATE of bug 357323

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	Macintosh Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Mylyn Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-04-18 17:40 EDT by Miles Parker
Modified:	2013-04-25 19:17 EDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Miles Parker

2013-04-18 17:40:44 EDT

I'm not getting the Submit button for a review that I have submit authorization for. In the Gerrit Review UI, I *can* submit by clicking "Review" and then choosing "Publish and Submit".

This looks like an issue with the Gerrit remote objects themselves. ChangeDetailX#canSubmit is false.

Comment 1 Steffen Pingel

2013-04-18 18:06:18 EDT

That could be expected. The web UI shows the Publish and Submit button even when not all requirements are satisfied. The Submit fails in a error if there are still approvals missing.

Comment 2 Miles Parker

2013-04-18 18:32:46 EDT

(In reply to comment #1)
> That could be expected. The web UI shows the Publish and Submit button even when
> not all requirements are satisfied. The Submit fails in a error if there are
> still approvals missing.

In this case I was able to then submit the review from the Web UI. But now that I think of it, I'm not sure I didn't end up changing some of the dialog buttons to +'s. But I don't want to pollute any of the reviews repos by trying it out now.

But in any case, I see what you're saying -- given that a committer would often click +2 or IP +1 or whatever as part of the submission, perhaps that's why canSubmit is false. I'm not sure if/how we should change this workflow short of waiting for a resolution to bug 396315 or at least bug 357323.

Comment 3 Steffen Pingel

2013-04-19 02:28:25 EDT

It seems best to me to implement bug 357323. It sounds like the Gerrit connector is working as expected.

Comment 4 Miles Parker

2013-04-25 19:17:08 EDT

Based on Steffen's comment, I think this is essentially a dup of bug 357323

*** This bug has been marked as a duplicate of bug 357323 ***