Community
Participate
Working Groups
4.x. Like other elements, the part tab should honor my system fonts. Usually, this corresponds to the Dialog font. The Eclipse preferences show that my system font is correctly set as Eclipse's dialog font, but the tab font seems to be hard-coded to Segoe UI. This is a major issue, because there is not other preference that would allow me to fix this issue and let Eclipse part tabs use the same font as every other tab my system.
*** Bug 387253 has been marked as a duplicate of this bug. ***
(In reply to comment #0) > This is a major issue, because there is not other preference that would > allow me to fix this issue and let Eclipse part tabs use the same font as > every other tab my system. There is a preference, but it does not work, see bug 355946. I know that there is a CSS Editor and I can change the font there. That's fine if I really want to make Eclipse/product specific changes. Out of the box that font value should be set to my system's defaults. The 'Windows 7' theme could be generated on the fly from my system defaults or it could leave the system specific entries empty and fallback to the system defaults when missing.
Submitted https://git.eclipse.org/r/#/c/20124/ for review. Actually the "fallback to the system defaults" feature was already there, but not working, due to CSSSWTFontHelper.getFontFamily adding double quotes around multi-word font names.
To use the ColorAndFontPreferencePage values you have to use the CSS bridge. Currently it is enabled for the Classic theme only (Bug 423704). In other cases the ColorAndFontPreferencePage settings will be overridden by CSS (font properties) or just ignored Daniel
(In reply to Daniel Rolka from comment #4) > To use the ColorAndFontPreferencePage values you have to use the CSS bridge. > Currently it is enabled for the Classic theme only (Bug 423704). In other > cases the ColorAndFontPreferencePage settings will be overridden by CSS > (font properties) or just ignored I'm not sure to what this comment refers, but I just want to repeat/clarify that this bug is about using the OS fonts out of the box, not making the preference page work again (which is bug 355946).
In addition to the previous commit: https://git.eclipse.org/r/#/c/20124/ which enables fallback to system default font, this new commit: https://git.eclipse.org/r/20753 changes the CSSs so that the system font is used by default. I made two commits because my understanding is that it is not possible to have one commit to two different projects.
(In reply to Piotr Aniola from comment #6) > In addition to the previous commit: > https://git.eclipse.org/r/#/c/20124/ > which enables fallback to system default font I don't think this change is needed. The quoting will be removed again later by the CSS engine (I think). At least for this bug the CSS change is enough to make the system font appear. However, instead of removing it entirely, it is better to use the new constant '#org-eclipse-ui-workbench-TAB_TEXT_FONT' like in other places. I've also removed the font-size. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=8cb3ea4bb672cdb2103766f887dc201ec3b69f6a
The quoting is added only for fonts with a '@' in front of the name or with spaces inside. Are you sure it works without my original change: https://git.eclipse.org/r/#/c/20124/ ? As far as I could tell/test/debug, the quoting is not removed by the CSS engine.
(In reply to Piotr Aniola from comment #8) > The quoting is added only for fonts with a '@' in front of the name or with > spaces inside. Are you sure it works without my original change: > https://git.eclipse.org/r/#/c/20124/ ? Yes I am sure and you can simply verify it using I20140119-2000. > As far as I could tell/test/debug, the quoting is not removed by the CSS > engine. OK. If you have a test case that surfaces a bug and which gets fixed by your change, please open a new bug report with those details.
