Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 405652 - [CDO] Add CDO integration feature to discovery
Summary: [CDO] Add CDO integration feature to discovery
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Others (show other bugs)
Version: 0.10.0   Edit
Hardware: PC Mac OS X
: P2 enhancement (vote)
Target Milestone: M7   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 290952
  Show dependency tree
 
Reported: 2013-04-12 17:05 EDT by Christian Damus CLA
Modified: 2013-04-25 10:36 EDT (History)
1 user (show)

See Also:
cletavernier: review+


Attachments
Patch adding CDO features to component discovery (7.72 KB, patch)
2013-04-12 18:04 EDT, Christian Damus CLA
no flags Details | Diff
What the discovery dialog looks like (270.22 KB, image/png)
2013-04-13 08:50 EDT, Christian Damus CLA
no flags Details
Updated screenshot for 72 dpi (205.03 KB, image/png)
2013-04-13 08:53 EDT, Christian Damus CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Damus CLA 2013-04-12 17:05:44 EDT
The CDO Integration feature can be expected to get more attention (and testing!) from the user community if it is discoverable in the Papyrus Additional Components discovery system.

So, it should be added to the discovery repository as an "experimental" component (this being its initial release).
Comment 1 Christian Damus CLA 2013-04-12 17:06:18 EDT
I'll work on this.
Comment 2 Christian Damus CLA 2013-04-12 18:04:43 EDT
Created attachment 229690 [details]
Patch adding CDO features to component discovery

Attached a patch that adds the CDO integration features (run-time and doc) to the additional components discovery manifest.

Note that

  * the icon is, of course, not actually in the patch
  * the M7 milestone P2 repository does not exist, yet, so
    I won't be able to push this until after M7
Comment 3 Christian Damus CLA 2013-04-12 18:06:07 EDT
Hi, Camille,

When you have a moment, I'd appreciate your review of the attached patch to ensure that I understood how the discovery manifest works and that it would be correct when published.

(note, of course, that this cannot be published until after M7)

Thanks!
Comment 4 Christian Damus CLA 2013-04-13 08:50:01 EDT
Created attachment 229693 [details]
What the discovery dialog looks like

I've attached a patch showing what the discovery dialog looks like when I direct it to the papyrus-extra.xmi in my local Git clone.

The other components indicate that they aren't available because the M2 repository that they point to for p2 URLs no longer exists.  I can fix that while I'm updating this file, anyways.
Comment 5 Christian Damus CLA 2013-04-13 08:53:46 EDT
Created attachment 229694 [details]
Updated screenshot for 72 dpi

Oops, I forgot that I'm on a "Retina" Mac display at 144 DPI graphics.  I've attached a new screenshot that is scaled down to what Windows PC users would see.
Comment 6 Camille Letavernier CLA 2013-04-15 03:56:08 EDT
Hi Christian,

> When you have a moment, I'd appreciate your review of the attached patch to ensure that I understood how the discovery manifest works and that it would be correct when published.

It's fine. I have a single comment, regarding the documentation (Related to Bug 405625). I think it's better to provide all the documentations in a single doc feature (Which already exists), than to include it with the extra-component. That's what I've done for the CSS component. It's an extra component, but the doc is part of the global Papyrus documentation feature, and it includes Installation steps.

So, the cdo.doc.feature should be removed from the discovery site.

Thank you
Comment 7 Christian Damus CLA 2013-04-15 06:58:17 EDT
Thanks, Camille. Wouldn't it be confusing, though, for users to see documentation of a component that isn't installed?  I would add a note that the CDO feature needs to be installed from via the discovery site, of course, but still ...

Moreover, this would mean that the main build has to be configured in the ramp to find the doc plug-in in the extra-plugins area.
Comment 8 Christian Damus CLA 2013-04-15 06:59:54 EDT
(In reply to comment #7)
> 
> Moreover, this would mean that the main build has to be configured in the
> ramp to find the doc plug-in in the extra-plugins area.

Oops, iPhone corrected the Buckminster "RMap" as "ramp".
Comment 9 Christian Damus CLA 2013-04-22 08:47:39 EDT
(In reply to comment #7)

Hi, Camille,

Sorry to nag, but do you have any comment on my concerns (below) ?

Thanks!

> Thanks, Camille. Wouldn't it be confusing, though, for users to see
> documentation of a component that isn't installed?  I would add a note that
> the CDO feature needs to be installed from via the discovery site, of
> course, but still ...
> 
> Moreover, this would mean that the main build has to be configured in the
> rmap to find the doc plug-in in the extra-plugins area.
Comment 10 Camille Letavernier CLA 2013-04-22 10:32:20 EDT
Hi Christian,

Sorry for the delay. I've asked the team, and it seems more interesting to provide the doc as part of the Papyrus main component (In the papyrus.doc feature). It gives more visibility to the component, and the user can have an overview of the component before actually installing it (So he can decide whether he needs it or not), as well as an installation guide.

The CDO doc plug-in can be moved to plugins/doc to avoid build issues (The rmap will still need to be updated, but it's not a big deal)
Comment 11 Christian Damus CLA 2013-04-22 20:27:56 EDT
Thanks, Camille.

I can add a bit to the doc, then, explaining how to install the CDO integration feature.

There is no plugins/doc folder:  shall I create it, then?  I suppose this is why you suggest that the rmap would still have to be updated, because if it doesn't exist, then obviously it isn't mapped, yet.
Comment 12 Camille Letavernier CLA 2013-04-23 04:54:02 EDT
Hi,

I've just added the doc folder to the SVN repo, and updated the rmap accordingly
Comment 13 Christian Damus CLA 2013-04-23 12:20:42 EDT
r10948:

The CDO doc plug-in is move from

svn+ssh://dev.eclipse.org/svnroot/modeling/org.eclipse.mdt.papyrus/trunk/extraplugins/cdo/org.eclipse.papyrus.cdo.ui.doc

to

svn+ssh://dev.eclipse.org/svnroot/modeling/org.eclipse.mdt.papyrus/trunk/plugins/doc/org.eclipse.papyrus.cdo.ui.doc

and is now included in the org.eclipse.papyrus.doc.feature feature.  The org.eclipse.papyrus.extra.cdo.doc feature is removed from the build.
Comment 14 Christian Damus CLA 2013-04-25 10:36:31 EDT
commit e16a9d2817da158e5adce3046e51d653d9a12328

As the doc plug-in is no longer included in the discovery component because it is now in the main build, there is no impediment to publishing the CDO Integration component in the discovery site.  I was only holding off until M7 because the documentation hadn't been published in any milestone update-site where discovery could find it.

So, the discovery site is now updated to publish the M6 milestone of the CDO Integration feature.