This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 405612 - [Model] TrimElement could be marked as interface
Summary: [Model] TrimElement could be marked as interface
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.4 M4   Edit
Assignee: Paul Elder CLA
QA Contact: Paul Elder CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-12 11:04 EDT by Szymon Ptaszkiewicz CLA
Modified: 2013-12-12 08:51 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Szymon Ptaszkiewicz CLA 2013-04-12 11:04:18 EDT 
It seems that TrimElementImpl is not used anywhere. In the UIElements.ecore file, the TrimElement doesn't have interface="true" property which then results in unnecessary class generation. If this class is meant only to exist as an interface like StackElement, WindowElement, PartSashContainerElement then it would be good to mark it as interface in the ecore and regenerate the model to make it as simple as possible.
Comment 1 Szymon Ptaszkiewicz CLA 2013-10-03 11:38:10 EDT 
Eric, does it sound reasonable to you?
Comment 2 Eric Moffatt CLA 2013-10-03 15:49:21 EDT 
Szymon, nice pickup :), yes 'TrimElement' should match the other 'containment' specifiers as being an interface...

I'll bundle this with a few other model changes that we'll be making soon, thanks a lot.
Comment 3 Eric Moffatt CLA 2013-11-25 16:02:51 EST 
Passing on to Paul...
Comment 4 Paul Elder CLA 2013-11-27 09:51:40 EST 
Pushed fix to Gerrit for review. Note that change does not affect API - only Javadoc and a small amount of EMF metadata has changed.

https://git.eclipse.org/r/18973
Comment 6 Paul Elder CLA 2013-12-10 14:11:51 EST 
In 4.4.0.I20131209-2000, noticed the TrimElementImpl is still present. Needs to be removed, as it is now dead code (EMF no longer generates it.)
Comment 7 Paul Elder CLA 2013-12-11 09:15:26 EST 
Patch to remove obsolete class TrimElementImpl.

https://git.eclipse.org/r/19648
Comment 9 Paul Elder CLA 2013-12-12 08:51:46 EST 
Verified in 4.4.0.I20131211-2000