Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 405351 - service configuration property page does not show which config is active or allow you to set the active config
Summary: service configuration property page does not show which config is active or a...
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Core (show other bugs)
Version: 6.0.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 6.0.6   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-10 08:53 EDT by Chris Recoskie CLA
Modified: 2013-05-09 10:51 EDT (History)
1 user (show)

See Also:


Attachments
add a label showing active config and a button to set active config. (5.61 KB, patch)
2013-05-01 12:56 EDT, cong wang CLA
no flags Details | Diff
latest patch. (6.35 KB, patch)
2013-05-08 16:44 EDT, cong wang CLA
recoskie: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Recoskie CLA 2013-04-10 08:53:24 EDT
With the property page the way it currently is, you have no way of knowing which config is active.  You also have no way of changing which one is active.
Comment 1 cong wang CLA 2013-05-01 12:56:40 EDT
Created attachment 230356 [details]
add a label showing active config and a button to set active config.
Comment 2 Chris Recoskie CLA 2013-05-03 17:12:18 EDT
I tried the patch... while the UI seems correct and it does seem to persist info from one instance of launching the property page to another, it doesn't seem like the project actually uses the config that you set as active after you click OK.
Comment 3 cong wang CLA 2013-05-08 16:44:36 EDT
Created attachment 230680 [details]
latest patch.
Comment 4 Chris Recoskie CLA 2013-05-09 10:51:06 EDT
Ok I applied the patch with some changes.  We can't hard code concatenation of strings for the UI as BIDI languages can require the strings to be ordered differently.  I added a pattern which is localized, and the pattern is passed to the message formatter to get the proper localized message.

Fixed on ptp_6_0 and master.