404566 – Add tie-breaking to editorInfoProvider extension point.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 404566 - Add tie-breaking to editorInfoProvider extension point.

Summary: Add tie-breaking to editorInfoProvider extension point.

Status:	RESOLVED FIXED

Alias:	None

Product:	PTP
Classification:	Tools
Component:	RDT (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	6.0.6
Assignee:	Chris Recoskie
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-03-28 10:52 EDT by Mike Kucera
Modified:	2013-04-11 11:08 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
patch (5.04 KB, patch) 2013-03-28 11:00 EDT, Mike Kucera	recoskie: iplog+	Details \| Diff
Fix to previous patch (564 bytes, patch) 2013-04-11 10:56 EDT, Mike Kucera	recoskie: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mike Kucera

2013-03-28 10:52:44 EDT

Comment 1 Mike Kucera

2013-03-28 11:00:57 EDT

Created attachment 229159 [details]
patch

Comment 2 Chris Recoskie

2013-04-02 12:48:12 EDT

Patch applied to ptp_6_0 and master.

Comment 3 Mike Kucera

2013-04-11 10:55:22 EDT

There's a mistake in my patch, the tie breaking code doesn't do the right thing. Its a dumb mistake on my part so I apologize. In RemoteCInfoProviderUtilities.getApplicableEditorInfoProvider() the local variable highestVal never gets updated so the last provider in the list always wins.

Comment 4 Mike Kucera

2013-04-11 10:56:02 EDT

Created attachment 229623 [details]
Fix to previous patch

Comment 5 Chris Recoskie

2013-04-11 11:08:02 EDT

Committed your additional fix.