Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 404492 - Editor theme font should not always be Courier
Summary: Editor theme font should not always be Courier
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 16:05 EDT by Mark Macdonald CLA
Modified: 2013-05-29 16:38 EDT (History)
3 users (show)

See Also:


Attachments
TextTheme patch (2.48 KB, text/plain)
2013-04-18 12:40 EDT, Bogdan Gheorghe CLA
no flags Details
Theme Data patch (3.33 KB, text/plain)
2013-04-18 12:41 EDT, Bogdan Gheorghe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2013-03-27 16:05:47 EDT
I noticed that the font used for all editor themes changed back to Courier recently. It's supposed to be something else (Lucida Console perhaps, I can't recall exactly).

I inspected the page CSS, I found this rule:

> .editorTheme {
>   font-family: monospace; /* XXX */
>   font-size: 10pt;
>   color: darkSlateGray;
> }

The font-family rule above overrides the fancy font set elsewhere in CSS, and resets it back to Courier. This is 2013, we are on the web and Courier is not cool anymore.
Comment 1 Silenio Quarti CLA 2013-03-27 16:20:28 EDT
We probably broke this with our theming changes for bug#401914.
Comment 2 Bogdan Gheorghe CLA 2013-04-18 12:40:43 EDT
Created attachment 229873 [details]
TextTheme patch

Patch for text theme
Comment 3 Bogdan Gheorghe CLA 2013-04-18 12:41:44 EDT
Created attachment 229874 [details]
Theme Data patch

Theme Data patch
Comment 5 Bogdan Gheorghe CLA 2013-04-18 15:33:29 EDT
Did some additional refactoring to simplify the number of stylesheets used (and added sans-serif to the list of fonts).

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=4087522cd40461f3dff5dc38330962dd3acbce87

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=5db8b6055ab34672a85ec7224f3170aef321580c