Community
Participate
Working Groups
Patch set 5 doesn't show up in the Gerrit editor for this review: 11431: 404315: [Textile] fix line break handling in Textile paragraphs [I114613aa] https://git.eclipse.org/r/#/c/11431/
Created attachment 229112 [details] screenshot of editor
Gerrit reviews feature version: 2.0.0.I20130319-0842
The problem doesn't appear to be specific to patch set #5, but the last patch set on the review
Miles, this could be related to moving code to in ReviewRemoteFactory. Can you take a look?
Yep. My guess is that it is probably something to do with the sequencing of the call back notification. I haven't been able to reproduce it yet here off current master or the April 1 drop (haven't tried it w/ milestone yet but there aren't any new reviews since then). I can get both patch set 5 and the last patch set. David, does this happen in all workflows to open this review editor, e.g. opening from task list, opening from link, open at startup.. ? And you're seeing it on the last patch set for all reviews, not just 11341?
I just saw they same problem. I opened a review that had an incoming and I suspect the full task data had not been downloaded. When I refreshed the editor the comments were refreshed as expected but the reviewers and patch set sections were not updated.
(In reply to comment #6) > I just saw they same problem. I opened a review that had an incoming and I > suspect the full task data had not been downloaded. When I refreshed the editor > the comments were refreshed as expected but the reviewers and patch set sections > were not updated. Thanks, that's really helpful. I think the key issue is the incoming. Does that fit with your experience, David? Please note that for better or worse :) this code has been heavily modified since the initial remote API review. We've made the Factory/Consumer interaction a lot more robust by adding in support for explicit listeners and ensuring that there is a 1:1 for Model-Object/Consumer throughout work bench. This supports decoupling of the UI from editor so all of this will be much cleaner when it is complete. But that will require much more competent job management including pooling server interactions. This is all in https://git.eclipse.org/r/#/c/11012/, but consider that an experimental branch for now -- I'll be breaking it out soon.
*** Bug 405504 has been marked as a duplicate of this bug. ***
Fixes are covered under https://git.eclipse.org/r/#/c/11012 -- see bug 400168 comment 2. You should be able to bootstrap that change to test fix.
Fixed in master: https://git.eclipse.org/r/#/c/11012/
