Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 404045 - Remote Inactive Code Highlighting in the Remote C/C++ Editor
Summary: Remote Inactive Code Highlighting in the Remote C/C++ Editor
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: RDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 6.0.6   Edit
Assignee: Chris Recoskie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 11:41 EDT by Mike Kucera CLA
Modified: 2013-04-04 15:34 EDT (History)
3 users (show)

See Also:

Attachments
Patch (45.88 KB, patch)
2013-03-21 12:04 EDT, Mike Kucera CLA 		no flags Details | Diff
Patch #2 (48.28 KB, patch)
2013-04-03 13:11 EDT, Mike Kucera CLA 		no flags Details | Diff
Patch 3 (49.94 KB, patch)
2013-04-03 16:41 EDT, Mike Kucera CLA 		recoskie: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kucera CLA 2013-03-21 11:41:36 EDT 
Highlight inactive code branches.
Comment 1 Mike Kucera CLA 2013-03-21 12:04:36 EDT 
Created attachment 228863 [details]
Patch
Comment 2 Chris Recoskie CLA 2013-04-01 11:40:26 EDT 
Mike, this patch has API errors.  It also introduces compile errors in Remote Tools.  Can you submit an updated patch?
Comment 3 Mike Kucera CLA 2013-04-03 13:11:56 EDT 
Created attachment 229291 [details]
Patch #2

I fixed the API errors by adding a new extension interface instead of adding the method to the existing interface. I don't know which plug-in had the remote tools compile error, but I think that should not be a problem with this new patch.
Comment 4 Mike Kucera CLA 2013-04-03 13:14:21 EDT 
Also, I was not aware that RDT is considered API now. You might want to consider removing the numerous comment blocks that declare RDT as experimental and not API.
Comment 5 Chris Recoskie CLA 2013-04-03 14:28:34 EDT 
Still errors...


Description	Resource	Path	Location	Type
The type RemoteToolsCIndexSubsystem must implement the inherited abstract method ICIndexSubsystem.computeInactiveHighlightPositions(ITranslationUnit)	RemoteToolsCIndexSubsystem.java	/org.eclipse.ptp.rdt.server.dstore/src/org/eclipse/ptp/rdt/server/dstore/core	line 103	Java Problem

Description	Resource	Path	Location	Type
The minor version should be incremented in version 4.2.0, since new APIs have been added since version 4.2.0	MANIFEST.MF	/org.eclipse.ptp.rdt.ui/META-INF	line 5	Version Numbering Problem
Comment 6 Mike Kucera CLA 2013-04-03 16:41:40 EDT 
Created attachment 229303 [details]
Patch 3
Comment 7 Chris Recoskie CLA 2013-04-04 14:30:46 EDT 
There were still API errors due to not upversioning the plugins.

I updated them and updated the pom.xml files to match.

Applied to ptp_6_0 and master.
Comment 8 Greg Watson CLA 2013-04-04 15:34:15 EDT 
I'm seeing API errors in RDT plugins after the last commit.