Comment 1 Paul Webster 2013-03-20 22:44:01 EDT

Created attachment 228771 [details]
patch.eclipse.platform.ua.R3_8_maintenance

Comment 2 Paul Webster 2013-03-20 22:44:25 EDT

Created attachment 228772 [details]
patch.eclipse.platform.ui.R4_2_maintenance

Comment 3 Paul Webster 2013-03-20 22:57:56 EDT

Created attachment 228794 [details]
patch.eclipse.platform.runtime.master

Comment 4 Paul Webster 2013-03-20 22:58:09 EDT

Created attachment 228795 [details]
patch.eclipse.platform.ua.master

Comment 5 Paul Webster 2013-03-20 22:58:24 EDT

Created attachment 228796 [details]
patch.eclipse.platform.ui.master

Comment 6 Paul Webster 2013-03-26 09:16:21 EDT

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f16e6cca7c0b742971503e50c5f1cdb6c84c02d9

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_2_maintenance&id=37d76ffd8277c4c2345bd8d6be048985dc661ed9

http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=4069ea9718102db6d035e7939ac9586e73fbbcef

http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?h=R3_8_maintenance&id=404cb6b4a76fac4e0fb368086a824e92a0216a70

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=f7384dbdfaca23b79978109ac9681abf5400db30

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?h=R4_2_maintenance&id=7510e8c3fb1ae64d8439b7d2ec1e890f7c636a5b

PW

Comment 7 Joseph Carroll 2013-03-26 09:31:53 EDT

@Paul-

I noticed in some of the pom's you changed the header so that it is all on a single line.  Is there a reason for this or is it just a formatting thing?

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/diff/tests/org.eclipse.e4.ui.tests/pom.xml?id=f16e6cca7c0b742971503e50c5f1cdb6c84c02d9

(Just curious is all, wasn't sure if having the header split between two lines could cause a parsing error or something)

JD

Comment 8 Paul Webster 2013-03-26 09:33:55 EDT

I was using xsltproc for this, and the tool + its formatting did it.

PW

Comment 9 Dani Megert 2013-03-27 10:52:31 EDT

Paul, shouldn't you also fix the parent pom for runtime and platform.ui in R3_8_maintenance? After all I've understood, it would make the 3.8.2+ build fail otherwise, no?

Comment 10 Joseph Carroll 2013-03-27 11:28:02 EDT

(In reply to comment #8)
> I was using xsltproc for this, and the tool + its formatting did it.
> 
> PW

Cool beans, thanks

Comment 11 Paul Webster 2013-03-27 11:32:16 EDT

(In reply to comment #9)
> Paul, shouldn't you also fix the parent pom for runtime and platform.ui in
> R3_8_maintenance? After all I've understood, it would make the 3.8.2+ build
> fail otherwise, no?

We haven't done the 3.8.2+ branches yet (I haven't prepared the patches on it) but we're not building 3.8.2+ yet (I'm not sure that it has made it into LTS).

I'll prepare the patches.

PW

Comment 12 Dani Megert 2013-03-27 11:34:57 EDT

(In reply to comment #11)
> (In reply to comment #9)
> > Paul, shouldn't you also fix the parent pom for runtime and platform.ui in
> > R3_8_maintenance? After all I've understood, it would make the 3.8.2+ build
> > fail otherwise, no?
> 
> We haven't done the 3.8.2+ branches yet (I haven't prepared the patches on
> it) but we're not building 3.8.2+ yet (I'm not sure that it has made it into
> LTS).
> 
> I'll prepare the patches

Thanks! It's better to do this right now, then we won't have surprises when we need to do some emergency builds in the future. Especially, since some of the R3_8_maintenance repos have been updated.

Comment 13 Lars Vogel 2013-03-27 11:38:51 EDT

Currently the CBI build breaks, looks like the pom changes for Eclipse 4.3 master are not completed. If I understood Paul, there are changes by other projects required. Do we have bugs for these changes?

Comment 14 Dani Megert 2013-03-27 11:45:36 EDT

(In reply to comment #13)
> Currently the CBI build breaks, looks like the pom changes for Eclipse 4.3
> master are not completed. If I understood Paul, there are changes by other
> projects required. Do we have bugs for these changes?

Look at the "blocks" bug ;-)

Comment 15 Lars Vogel 2013-03-27 13:13:19 EDT

Thanks Dani

Comment 16 Paul Webster 2013-03-27 17:49:12 EDT

Fixed in 3.8.2+ with:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_8_maintenance&id=b039be55127e2dcc089bb86ff2cf19ecaf70d1c8

http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?h=R3_8_maintenance&id=82f206e099c31658aecf630e3ee5df37410c4a67

PW