403893 – [console] New Console does not support CommandInterpreter#execute()

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 403893 - [console] New Console does not support CommandInterpreter#execute()

Summary: [console] New Console does not support CommandInterpreter#execute()

Status:	CLOSED FIXED

Alias:	None

Product:	Equinox
Classification:	Eclipse Project
Component:	Components (show other bugs)
Version:	unspecified
Hardware:	PC Windows 8

Importance:	P3 normal (vote)
Target Milestone:	Kepler M7
Assignee:	Lazar Kirchev
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-03-20 09:51 EDT by Gunnar Wagenknecht
Modified:	2013-04-05 09:34 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Gunnar Wagenknecht

2013-03-20 09:51:25 EDT

The new console removed a feature of commands written using CommandProvider and CommandInterpreter.

Commands were allowed to execute other commands by calling CommandInterpreter#execute() on the CI object they received when they are executed. We use this a lot for providing convenience and composite commands.

I recently updated one of those larger applications to the new console and all the commands stopped working. Sorry for not detecting earlier. But IMHO this is a regression. With the introduction of the new console, neither CommandProvider nor ConsoleInterpreter has been deprecated.

Comment 1 Gunnar Wagenknecht

2013-03-20 11:05:54 EDT

Pushed fix:
https://github.com/eclipseguru/rt.equinox.bundles/commit/70d9aa5748f9708b025c79bc0a2f5f30356d2764

Comment 2 Gunnar Wagenknecht

2013-03-20 11:06:41 EDT

Sorry about the layout of the change. For some reason it always removes whitespaces.

Comment 3 Gunnar Wagenknecht

2013-03-20 11:07:17 EDT

Note, the fix was a very quick one after hints from Lazar.

Comment 4 Thomas Watson

2013-03-20 11:19:41 EDT

Thanks Gunnar!

Lazar could you review Gunnar's fix and release for M7 if appropriate?

Comment 5 Lazar Kirchev

2013-03-27 20:14:45 EDT

Thanks Gunnar! Reviewd and submitted with commit http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=39af747aa850411e67c0f40efe8cd16017263396

Comment 6 Lazar Kirchev

2013-03-27 20:15:07 EDT

Fixed.

Comment 7 Lazar Kirchev

2013-04-05 09:34:55 EDT

Closing the bug.