403760 – closing the last maximized editor doesnt restore perspective layout

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 403760 - closing the last maximized editor doesnt restore perspective layout

Summary: closing the last maximized editor doesnt restore perspective layout

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.4
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	4.4 M2
Assignee:	Platform-UI-Inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-03-19 08:10 EDT by Missing name
Modified:	2013-09-16 11:36 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Step 1 (Java Perspective) (82.82 KB, image/png) 2013-08-26 16:05 EDT, Missing name	no flags	Details
Step 2 (Java Perpective) (36.92 KB, image/png) 2013-08-26 16:06 EDT, Missing name	no flags	Details
Step 3 (Java Perspective) (66.57 KB, image/png) 2013-08-26 16:06 EDT, Missing name	no flags	Details
Step 1 (Debug Perspective) (50.77 KB, image/png) 2013-08-26 16:07 EDT, Missing name	no flags	Details
Step 2 (Debug Perspective) (37.76 KB, image/png) 2013-08-26 16:07 EDT, Missing name	no flags	Details
Step 3 (Debug Perspective) (24.29 KB, image/png) 2013-08-26 16:08 EDT, Missing name	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Missing name

2013-03-19 08:10:15 EDT

This happens in all perspectives I tried except Java Perspective.

For instance in 
* Debug
* CVS Repo Exploring
* Synchronize

Steps to reproduce
1. open a file in an editor with no other open editors
2. maximize editor
3. close editor

Result:
all views in the perspective remain minimized

Expected Result:
view get shown again


-- Configuration Details --
Product: Eclipse SDK 4.2.2.v201302041200 (org.eclipse.sdk.ide)
Installed Features:
 org.eclipse.platform 4.2.1.v20130118-173121-9MF7GHYdG0B5kx4E_SkfZV-1mNjVATf67ZAb7

Comment 1 Joseph Carroll

2013-03-19 11:11:22 EDT

I believe this bug is directly related to bug 394395

@Committers - Mark as duplicate?

Comment 2 Missing name

2013-08-16 10:21:26 EDT

This still happens in Eclipse 4.3

Comment 3 Curtis Windatt

2013-08-19 11:04:57 EDT

Works fine in 4.4 and 4.3.1.  What build are you still seeing this in?

*** This bug has been marked as a duplicate of bug 394395 ***

Comment 4 Missing name

2013-08-26 16:04:50 EDT

This is not a duplicate.
I am attaching a few screenshots to document this.

Comment 5 Missing name

2013-08-26 16:05:42 EDT

Created attachment 234760 [details]
Step 1 (Java Perspective)

Comment 6 Missing name

2013-08-26 16:06:12 EDT

Created attachment 234761 [details]
Step 2 (Java Perpective)

Comment 7 Missing name

2013-08-26 16:06:41 EDT

Created attachment 234762 [details]
Step 3 (Java Perspective)

Comment 8 Missing name

2013-08-26 16:07:12 EDT

Created attachment 234763 [details]
Step 1 (Debug Perspective)

Comment 9 Missing name

2013-08-26 16:07:46 EDT

Created attachment 234764 [details]
Step 2 (Debug Perspective)

Comment 10 Missing name

2013-08-26 16:08:12 EDT

Created attachment 234765 [details]
Step 3 (Debug Perspective)

Comment 11 Missing name

2013-08-26 16:09:43 EDT

This screenshots were just taken from Eclipse 4.4M1.
As you can see the workbench behaves differently after closing the maximized editor in Java and Debug perspectives.

Comment 12 Dani Megert

2013-08-27 09:29:41 EDT

(In reply to comment #11)
> This screenshots were just taken from Eclipse 4.4M1.
> As you can see the workbench behaves differently after closing the maximized
> editor in Java and Debug perspectives.

Can be reproduced using 4.4 M1 and new workspace.

Comment 13 Eric Moffatt

2013-08-27 17:15:10 EDT

I've located the issue and I'll fix it tomorrow. The problem is in the 
unzoomSharedArea() in WorkbenchPage where it searches the 'window' for the shared area placeholder rather than the current perspective. Each perspective has its own placeholder (and its own max/min state).

Comment 14 Eric Moffatt

2013-08-27 17:16:00 EDT

Btw the test is that it's not tied to any particular perspective, just the first one in the stack.

Comment 15 Eric Moffatt

2013-08-28 09:31:26 EDT

COmmitted:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e87eb3fa52294db594ad8aa3bbfd0e91ae480f0a

The unzoomSharedArea() method now correctly locates the correct placeholder.

NOTE: I really think that this constitutes bad UI behavior. The *User* has maximized the EA and I don't think it's appropriate that the IDE arbitrarily decides that they were wrong.

Why do you folks think that this is good ? You can still access your views...

Comment 16 Eric Moffatt

2013-09-16 11:36:13 EDT

Verified in 4.4.0.I20130915-2000.

Verified as 'fixed'. The first (external) defect that comes in saying that this is bad will also likely get 'fixed'...