Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 403583 - show icons in the model editor tree
Summary: show icons in the model editor tree
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Olivier Prouvost CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-17 16:45 EDT by Wim Jongman CLA
Modified: 2015-05-11 14:48 EDT (History)
3 users (show)

See Also:

Attachments
shows where icons are missing (18.47 KB, image/png)
2013-03-17 16:48 EDT, Wim Jongman CLA 		no flags Details
The result (254.25 KB, image/png)
2015-04-20 10:08 EDT, Olivier Prouvost CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2013-03-17 16:45:58 EDT 
Icons are not shown in the model editor tree. Only when hovered over an icon uri the become visible.
Comment 1 Wim Jongman CLA 2013-03-17 16:48:35 EDT 
Created attachment 228547 [details]
shows where icons are missing
Comment 2 Olivier Prouvost CLA 2015-03-26 08:27:02 EDT 
I just changed it and pushed a review. 
IT REALLY CHANGES THE EDITOR AND THIS WAS A GREAT IDEA ! 


Hmm... it seems that my gerrit configuration was not set and I pushed it directly in master !??? Sorry about that  ! There is no lock for this ?
Comment 3 Olivier Prouvost CLA 2015-03-26 08:46:10 EDT 
Fixed with this commit : 

https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=f9879fe13ad3be8a77c7acfb0739974d3c73b2d9

Sorry I bypassed the gerrit review due to my configuration on this new project !
Comment 4 Wim Jongman CLA 2015-03-26 09:28:57 EDT 
(In reply to Olivier Prouvost from comment #3)
> Fixed with this commit : 
> 
> https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/
> ?id=f9879fe13ad3be8a77c7acfb0739974d3c73b2d9
> 
> Sorry I bypassed the gerrit review due to my configuration on this new
> project !

How can you push? I missed your election as platform.ui committer?
Comment 5 Lars Vogel CLA 2015-04-02 10:56:08 EDT 
(In reply to Wim Jongman from comment #4)
> (In reply to Olivier Prouvost from comment #3)
> How can you push? I missed your election as platform.ui committer?

Maybe the permissions are currently so that e4 and platform.ui committer can push to it? I call that a feature, lets leave it like this, until someone complains.
Comment 6 Olivier Prouvost CLA 2015-04-20 10:08:29 EDT 
Created attachment 252545 [details]
The result

The result added also in the N&N for M7
Comment 7 Olivier Prouvost CLA 2015-04-23 11:10:13 EDT 
I created a new bug (#465271) to fix some other issues relative to icons.
Comment 8 Olivier Prouvost CLA 2015-04-23 11:11:05 EDT 
I created a new bug (bug #465271) to fix some other issues relative to icons.
Comment 9 Lars Vogel CLA 2015-05-08 04:46:26 EDT 
This change broke the display of the icon in the tree for me.
Comment 10 Olivier Prouvost CLA 2015-05-11 06:40:35 EDT 
This bug has been fixed with a the review https://git.eclipse.org/r/#/c/46354/ which has not been merged.. 

I will recheck it again but it should not be a big issue...
Comment 11 Lars Vogel CLA 2015-05-11 06:50:15 EDT 
(In reply to Olivier Prouvost from comment #10)
> This bug has been fixed with a the review
> https://git.eclipse.org/r/#/c/46354/ which has not been merged.. 

See review in this bug, it did not fix this issue for me.

> I will recheck it again but it should not be a big issue...
Comment 12 Lars Vogel CLA 2015-05-11 14:48:16 EDT 
(In reply to Lars Vogel from comment #9)
> This change broke the display of the icon in the tree for me.

This has been fixed via Bug 465271.
Comment 13 Lars Vogel CLA 2015-05-11 14:48:30 EDT 
.