Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 403490 - treetable - use of tables vs. divs
Summary: treetable - use of tables vs. divs
Status: RESOLVED WONTFIX
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 403483
  Show dependency tree
 
Reported: 2013-03-15 12:01 EDT by Susan McCourt CLA
Modified: 2015-05-05 16:01 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2013-03-15 12:01:30 EDT
treetable.js originally evolved as a component that can manage a tabular view of data.  It used HTML table elements for its DOM.

At some point, the ability to describe the elements that should be used was added.  

this._tableElement = options.tableElement || "table"; //$NON-NLS-0$
this._tableBodyElement = options.tableBodyElement || "tbody"; //$NON-NLS-0$
this._tableRowElement = options.tableRowElement || "tr"; //$NON-NLS-0$

I'm guessing that there were styling challenges, etc. with tables and that a move to divs simplified things for certain cases.

If we ever start to support treetable as a consumable component outside of Orion, we might want to consider keeping the treetable representation internal (always divs?) rather than exposing this level of customization.  Not sure.
Comment 1 Susan McCourt CLA 2013-03-15 12:12:59 EDT
A better approach might be to have the creator set a template for the "outer layer" of explorers and then template the rows.  This gives the same level of control as we have now but in a more "typical" way.  ie...if the client cares about the DOM structure underneath they should own it vs. setting some flags that "sort of" control it.
Comment 2 John Arthorne CLA 2015-05-05 15:48:00 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
Comment 3 John Arthorne CLA 2015-05-05 16:01:24 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:


https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html