This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 403331 - ModelAssembler fails silently if fragment cannot be applied and does not print name of offending bundle
Summary: ModelAssembler fails silently if fragment cannot be applied and does not prin...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.4 M1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 411051
  Show dependency tree
 
Reported: 2013-03-14 08:31 EDT by Philip Wenig CLA
Modified: 2013-08-07 13:38 EDT (History)
5 users (show)

See Also:

Attachments
Patch (662 bytes, patch)
2013-03-14 08:31 EDT, Philip Wenig CLA 		no flags Details | Diff
Revised patch logging the location in a second location (991 bytes, text/plain)
2013-05-22 09:45 EDT, Markus Kuppe CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Wenig CLA 2013-03-14 08:31:09 EDT 
Created attachment 228418 [details]
Patch

If the ModelAssembler class fails to merge a model fragment with the runtime application model, it fails without an info message on the console. This makes it hard to identify the problem. 

Together with Markus Kuppe and Lars Vogel we created the following attached patch to give a info message.
Comment 1 Markus Kuppe CLA 2013-05-22 09:45:01 EDT 
Created attachment 231302 [details]
Revised patch logging the location in a second location
Comment 2 Lars Vogel CLA 2013-05-23 16:15:11 EDT 
@Eric/ Paul, could you apply this fix? It is just an improved error message so the risk is low.We had twice customer which forgot to add their fragment.e4xmi to the build.properties of a large project and it cost us some time to debug which one it is without this fix.
Comment 3 Paul Webster CLA 2013-05-23 16:41:58 EDT 
We can put it in 4.3.1 now

PW
Comment 4 Markus Kuppe CLA 2013-05-24 05:04:35 EDT 
(In reply to comment #3)
> We can put it in 4.3.1 now


Hi Paul,

what is the policy that prevents this from going into 4.3.0?
Comment 5 Paul Webster CLA 2013-05-24 06:45:36 EDT 
RC2 has had its final build, and is just waiting for a Go from the various platforms.

And RC3 should only have fixes that are serious problems to the general workflow (like keys in one editor going to another) or documentation plugin changes.

http://www.eclipse.org/eclipse/development/plans/freeze_plan_4_3.php#FixPassAfterRC2

PW
Comment 6 Markus Kuppe CLA 2013-06-11 15:18:29 EDT 
Gerrit change with my patch:

https://git.eclipse.org/r/#/c/13756/
Comment 8 Paul Webster CLA 2013-08-07 13:38:15 EDT 
In 4.4.0.I20130806-2000

PW