Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 402649 - javax.annotations and javax.inject sources missing in SDK build
Summary: javax.annotations and javax.inject sources missing in SDK build
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.3.1   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 387052
  Show dependency tree
 
Reported: 2013-03-07 08:32 EST by Markus Keller CLA
Modified: 2013-08-28 10:05 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2013-03-07 08:32:53 EST 
Source bundles for javax.annotations and javax.inject are missing in the SDK build.

For other similar bundles like javax.el and javax.servlet, source bundles are there.
Comment 1 David Williams CLA 2013-03-23 15:57:01 EDT 
The (non) source bundles are included in org.eclipse.e4.rcp feature, so will be up to UI to solve. 

I do see that in their pom.xml the explicitly exclude source for 
                <plugin id="javax.xml"/>
                <plugin id="javax.annotation"/>
                <plugin id="javax.inject"/>
                <plugin id="org.apache.batik.css"/>
                <plugin id="org.apache.batik.util"/>
                <plugin id="org.apache.batik.util.gui"/>

and others. 

Not sure if that's because they explicitly did not want ... or, if there is (or should be) an explicit org.eclipse.e4.rcp.source feature? Or, might be that 'source' doesn't exist for these in Orbit? From a quick scan, only "javax.xml" has no source in Orbit, but I did note check versions required.
Comment 2 Dani Megert CLA 2013-03-25 11:04:40 EDT 
FWIW, this was also missing with the PDE build.
Comment 3 Markus Keller CLA 2013-06-03 13:46:14 EDT 
This is even more severe now that the SDK claims to ship with e4 APIs. A sane developer cannot use any of these annotations without seeing their specification.

For RC4, we could at least add attached Javadoc, i.e. add this to org.eclipse.platform.doc.isv's contribution to "org.eclipse.pde.core.javadoc":

       <javadoc path="http://docs.oracle.com/javaee/6/api/">
          <plugin id="javax.inject"/>
       </javadoc>
       <javadoc path="http://docs.oracle.com/javase/7/docs/api/">
          <plugin id="javax.annotation"/>
       </javadoc>
Comment 4 Paul Webster CLA 2013-08-22 11:14:18 EDT 
I've removed the exclusions from the pom and I've run a local test build.  The source bundles get included in the e4.rcp.source feature.

for 4.3.1: https://git.eclipse.org/r/15781

PW
Comment 5 David Williams CLA 2013-08-22 11:23:58 EDT 
Is this a dup of bug 387052, or is there still more to do?
Comment 6 Paul Webster CLA 2013-08-22 11:52:00 EDT 
Yes, this looks to be 2 bundles out of the list from bug 387052

PW
Comment 7 Dani Megert CLA 2013-08-23 03:45:02 EDT 
(In reply to comment #4)
> I've removed the exclusions from the pom and I've run a local test build. 
> The source bundles get included in the e4.rcp.source feature.
> 
> for 4.3.1: https://git.eclipse.org/r/15781
> 
> PW

Submitted and updated the feature version.
Comment 8 Dani Megert CLA 2013-08-23 03:53:32 EDT 
Note that the fix also went into 'master' with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e3198b48b51a9b2cdb4b3dca7818ee767853fec
Comment 9 Paul Elder CLA 2013-08-26 14:37:08 EDT 
Verified in build 4.3.0.M20130821-0800.
Comment 10 Paul Elder CLA 2013-08-28 10:05:26 EDT 
Per comment 9, state should be Verified
Comment 11 Paul Elder CLA 2013-08-28 10:05:39 EDT 
Verified per comment 9