Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 402527 - Upgrade to Jetty 8.1.9 for Kepler
Summary: Upgrade to Jetty 8.1.9 for Kepler
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.3   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 09:52 EST by Thomas Watson CLA
Modified: 2013-03-07 12:19 EST (History)
2 users (show)

See Also:

Attachments
parent pom.xml changes for new jetty 8.1.9 repo URL (1.27 KB, patch)
2013-03-07 08:56 EST, Thomas Watson CLA 		no flags Details | Diff
org.eclipse.sdk patch to update jetty versions in build.properties (2.11 KB, patch)
2013-03-07 08:57 EST, Thomas Watson CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Watson CLA 2013-03-06 09:52:50 EST 
We need to update the the parent pom [1] to point to the new jetty repo [2].  And we need to update the build.properties[3] of the org.eclipse.sdk feature to indicate the new versions of the jetty bundles (8.1.9).

[1] http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/tree/eclipse-platform-parent/pom.xml

[2] http://download.eclipse.org/jetty/updates/jetty-bundles-8.x/8.1.9.v20130131

[3] http://git.eclipse.org/c/platform/eclipse.platform.releng.git/tree/features/org.eclipse.sdk/build.properties

I will attach patches for these changes.  But it will be another day until I can confirm a good local build with them.  On my machine it takes > 3 hours to build and it also uses up most of my machines memory so I cannot do a proper build until  overnight.
Comment 1 Thomas Watson CLA 2013-03-07 08:56:42 EST 
Created attachment 228065 [details]
parent pom.xml changes for new jetty 8.1.9 repo URL
Comment 2 Thomas Watson CLA 2013-03-07 08:57:26 EST 
Created attachment 228066 [details]
org.eclipse.sdk patch to update jetty versions in build.properties
Comment 3 Thomas Watson CLA 2013-03-07 09:01:18 EST 
I ran a local build with these changes and it produced the expected SDK with the 8.1.9 jetty bundles.  I was able to bring up Eclipse help and did some sniff testing of the functionality.  I would like to get this released to get additional testing for M6.
Comment 4 David Williams CLA 2013-03-07 09:35:54 EST 
I must have missed this in Git/EGit 101 class ... how am I to apply a patch like these? They don't "apply" using my version of Eclipse. 

I mean, I could guess what needs to change ... but, I think I'm missing something?
Comment 5 Thomas Watson CLA 2013-03-07 10:20:23 EST 
(In reply to comment #4)
> I must have missed this in Git/EGit 101 class ... how am I to apply a patch
> like these? They don't "apply" using my version of Eclipse. 
> 
> I mean, I could guess what needs to change ... but, I think I'm missing
> something?

These are standard git patches, when applied using git command line the will preserve the author as myself and you as the committer.  I do it by using this command:

git am < /path/to/patch/file
Comment 6 David Williams CLA 2013-03-07 12:19:46 EST 
Thanks for the education. 

Sorry, you lost author ship for the URL one ... I'd already pasted it in. 

But, should be in next build. 

Thanks.