Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 402454 - Please add support for pax-web HttpService registerFilter method for equinox running in Apache Karaf
Summary: Please add support for pax-web HttpService registerFilter method for equinox ...
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Server-Side (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: Kepler M7   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 11:43 EST by Dan Dumont CLA
Modified: 2013-04-02 11:37 EDT (History)
2 users (show)

See Also:


Attachments
support karaf registerFilter method signature (1.91 KB, application/octet-stream)
2013-03-05 11:43 EST, Dan Dumont CLA
no flags Details
support karaf registerFilter method signature (1.92 KB, application/octet-stream)
2013-03-05 12:35 EST, Dan Dumont CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Dumont CLA 2013-03-05 11:43:02 EST
Created attachment 227945 [details]
support karaf registerFilter method signature

In an environment set up like so: 
https://github.com/OpenNTF/JavascriptAggregator/wiki/Running-the-sample-application-in-Apache-Karaf

Which otherwise works quite well, bundles cannot register javax.servlet.Filter classes because the HttpService impl Karaf uses chose to implement the method another way.

I have attached a patch to make this work.  Please consider it for a backport to the version of equinox that Karaf currently supports (3.8)
Comment 1 Dan Dumont CLA 2013-03-05 12:35:45 EST
Created attachment 227949 [details]
support karaf registerFilter method signature

Updated patch for registerFilter
Comment 2 Thomas Watson CLA 2013-04-02 11:15:02 EDT
I will review.
Comment 3 Thomas Watson CLA 2013-04-02 11:30:18 EDT
Patch released:

http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=2048b3dcb40d153ee9e67358a5a3bbd37a2f71f7

Thanks for the contribution!
Comment 4 Dan Dumont CLA 2013-04-02 11:37:01 EDT
Thanks!   Can this make it into a 3.8 release or official build of equinox?  And if it does, where will I be able to find it?