Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 401505 - Inefficient Algorithm for checkAmbiguousDefinitions
Summary: Inefficient Algorithm for checkAmbiguousDefinitions
Status: CLOSED FIXED
Alias: None
Product: M2T
Classification: Modeling
Component: Xpand (show other bugs)
Version: 1.3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: M7   Edit
Assignee: Karsten Thoms CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 05:35 EST by Benedikt Niehues CLA
Modified: 2017-10-31 11:25 EDT (History)
1 user (show)

See Also:
karsten.thoms: kepler+

Attachments
Testcases for Ambiguous checks (12.22 KB, application/octet-stream)
2013-02-22 06:47 EST, Benedikt Niehues CLA 		karsten.thoms: iplog+
Details
Fix for this bug (9.82 KB, application/octet-stream)
2013-02-22 06:48 EST, Benedikt Niehues CLA 		karsten.thoms: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benedikt Niehues CLA 2013-02-22 05:35:18 EST 
During the analyzation of extensions a check for ambiguous extensions is performed. So each extensions searches for a duplicate extension on a list of all extensions. If the ambiguous check is performed for an ExtensionFile over all containing extensions, the performance would be increased.
Comment 1 Benedikt Niehues CLA 2013-02-22 06:47:16 EST 
Created attachment 227450 [details]
Testcases for Ambiguous checks

Testcases
Comment 2 Benedikt Niehues CLA 2013-02-22 06:48:01 EST 
Created attachment 227451 [details]
Fix for this bug
Comment 3 Karsten Thoms CLA 2013-02-22 08:15:32 EST 
Patch applied and verified. Thanks!

Commit c7ef7779cf561c8f0ac7b52c73d9fec88036de2b
Comment 4 Karsten Thoms CLA 2013-03-05 04:32:28 EST 
Had a problem with Git, change was not on master. Sorry, did not make it for 1.3.0.
Comment 5 Karsten Thoms CLA 2013-03-05 04:33:20 EST 
Change pushed now in master.
Comment 6 Eclipse Webmaster CLA 2017-10-31 11:25:55 EDT 
Requested via bug 522520.

-M.