Community
Participate
Working Groups
In the most recent build, if you blow away your cache and start from the login screen: 1. Click on some favorite link and notice it opens properly in an editor page. 2. Go back to the navigator and click on another link. Notice it opens as just a file (ie. no editor page),
I checked all this when working bug 387488 and then bug 398643, but perhaps there is still some kind of race condition or problem with first time use.
Indeed. It's basically the problem described in bug 387488 comment 4. The open with commands must be processed before we can generate favorites links. My original fix worked, but was naive. It moved the call to generate favorites to occur after the call to process the open with commands. However the open with commands are processed asynchronously (to get content types, to read NLS keys, etc.) so that fix was still ripe for a race condition. I know that the timing of the code on this page changed when we NLS'ed the create new content extension points (more asynch calls to get NLS keys) so I'm guessing this changed the timing. Or it could have been some other change. The point is that we need to return a deferred when we process the open with commands and then anyone depending on the timing can wait on that deferred. I have a fix, just trying to get it pushed somewhere.
Created attachment 227421 [details] fileCommands patch one of two
Created attachment 227422 [details] table patch, two of two
I have managed to get myself locked out of localhost and cannot push this commit. So...here it is as two patch files. To further complicate matters, the diff view sees the entire file changing, perhaps it's a line break thing. I found that once I was able to stage the commits, the diff looked reasonable. I have tested the fix and it definitely solves the problem for good. Mark, could you possibly take these patches, review, and if approved, please commit/push them?
I pushed the patches to this branch for review: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/?h=bug401449
Looks good +
Attempting to push...
Pushed to master - waiting for build server to come back online
.
