This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 400704 - Remove copy of Deferred from editor
Summary: Remove copy of Deferred from editor
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Editor (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0 RC1   Edit
Assignee: Silenio Quarti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 10:50 EST by Silenio Quarti CLA
Modified: 2013-05-29 16:42 EDT (History)
1 user (show)

See Also:
simon_kaegi: review+

Attachments
patch (12.60 KB, text/plain)
2013-02-13 10:52 EST, Silenio Quarti CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Silenio Quarti CLA 2013-02-13 10:50:17 EST 
Now that we have created the core bundle and moved the UI code out, we believe it is appropriate for the editor bundle to have a dependency on core. We should stop copying Deferred into the editor bundle.
Comment 1 Silenio Quarti CLA 2013-02-13 10:52:00 EST 
Created attachment 227027 [details]
patch
Comment 2 Silenio Quarti CLA 2013-02-13 11:00:40 EST 
Simple change: deleted orion/editor/Deferred.js and changed dependency of contentAssist.js from "orion/editor/Deferred" to "orion/Deferred".  The tests already depended on "orion/Deferred".