Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400647 - Ensuring Index is up to date takes too long when Previewing a refactoring a 2nd time
Summary: Ensuring Index is up to date takes too long when Previewing a refactoring a 2...
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 8.1   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 00:43 EST by Louis Orenstein CLA
Modified: 2013-04-29 18:38 EDT (History)
1 user (show)

See Also:


Attachments
proposed patch (2.48 KB, text/plain)
2013-02-13 00:43 EST, Louis Orenstein CLA
no flags Details
updated patch (3.86 KB, text/plain)
2013-02-19 10:06 EST, Louis Orenstein CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Louis Orenstein CLA 2013-02-13 00:43:29 EST
Created attachment 226977 [details]
proposed patch

If a user decides to Preview a refactoring, then uses the "Back" button, then decides to "Preview" again, there is an un-necessary delay before the 2nd Preview appears, and the Progress Monitor iterates through all of the files in the project with the message "Ensuring index is up to date - <filename>"

In the background, the process that actually ensures the index is up to date usually completes in under 1 second, but the progress monitor takes quite a bit longer to finishing displaying all of its messages.
Comment 1 Jeffrey Overbey CLA 2013-02-13 13:08:58 EST
Hi Lou,

Thanks for the patch!  If you don't mind, please modify your patch so that

(1) you are listed as one of the contributors in the copyright header of any affected files (e.g., "Louis Orenstein (Tech-X Corporation) - Fix for Bug XXXXX" or something similar), and
(2) you are listed as an @author in the JavaDoc for any affected classes.

(These are required by the IP team at the Eclipse Foundation.)

After you submit the modified patch, please confirm that

(a) you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,
(b) you have the right to contribute the code to Eclipse, and
(c) you have included the EPL license header in all source files.

Thanks!
Comment 2 Louis Orenstein CLA 2013-02-19 10:06:50 EST
Created attachment 227257 [details]
updated patch

updated contributors and javadoc authors sections

I confirm that:

(a) I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others.
(b) I have the right to contribute the code to Eclipse.
(c) I have included the EPL license header in all new source files. (VPGRefactoring did not already have the EPL header, but I can add it if necessary)
Comment 3 Jeffrey Overbey CLA 2013-04-29 18:16:57 EDT
This is a small patch, so I was able to commit it without a full IP review.  Thanks again, Lou.

Applied in master for Kepler GA.