Community
Participate
Working Groups
I tried ctrl+shift+h to open a commit from git repo page and nothing happened on Chrome. The binding does show up in the key help so I think the command itself is failing.
I investigated this a bit since it's a regression. The command is never being called because the command is contributed to a scope called "reposPageActions" (plural) but the only commands ever rendered into the page are from the scope "repoPageAction" (singular). I'm not sure of the intention here. Is the presence of both scopes a typo or is this a differentiation between the page mode showing multiple repos vs. one repo? If the difference is intentional, then the fix is to contribute the command to "repoPageAction" (singular) on line 57 of git-repository.js I just wasn't sure. This seems like a safe/simple fix. Note that open commit still works as expected on the git commit page.
http://localhost:8080/git/reviewRequest.html#ssh://git.eclipse.org/gitroot/orion/org.eclipse.orion.client.git_56a5a719322c4291142373499783da299298de32 Gosia please review. I understand we have +1 from you Simon on it?
+1: code looks good and works.
Fixed.
