Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 400541 - Create a "org.eclipse.scout.testing.commons" plugin
Summary: Create a "org.eclipse.scout.testing.commons" plugin
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: migration
Keywords:
Depends on: 402308
Blocks: 402301
  Show dependency tree
 
Reported: 2013-02-12 05:01 EST by Jeremie Bresson CLA
Modified: 2021-08-19 11:20 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremie Bresson CLA 2013-02-12 05:01:40 EST 
There is a need a org.eclipse.scout.testing.commons plugin containing "testing support" classes from org.eclipse.scout.testing.shared that do not depend on org.eclipse.scout.shared

2 concerned classes are:
- org.eclipse.scout.rt.testing.shared.OsUtility
- org.eclipse.scout.rt.testing.shared.ScoutAssert

They should be moved to:
- org.eclipse.scout.rt.testing.commons.OsUtility
- org.eclipse.scout.rt.testing.commons.ScoutAssert

The new plugin should not have any dependency to "org.eclipse.scout.shared"
Comment 1 Jeremie Bresson CLA 2013-02-12 05:30:11 EST 
> Input Judith Gull:

Mark the old class depreciated (analog to org.eclipse.scout.rt.server.servlet.filter.BasicSecurityFilter) with an hint, that the class will be removed with the L-Release.
Comment 2 Ken Lee CLA 2013-02-12 07:38:48 EST 
(In reply to comment #1)
> Mark the old class depreciated (analog to
> org.eclipse.scout.rt.server.servlet.filter.BasicSecurityFilter) with an
> hint, that the class will be removed with the L-Release.

+1
Comment 3 Jeremie Bresson CLA 2013-03-04 06:02:06 EST 
@Ken: we have started something on GitHub. Can we finished it and push it to master?
Comment 4 Jeremie Bresson CLA 2013-03-04 12:42:29 EST 
MIGRATION:

1. Update imports

Old (depreciated) :
import org.eclipse.scout.rt.testing.shared.ScoutAssert;
import org.eclipse.scout.rt.testing.shared.OsUtility;

New (depreciated) :
import org.eclipse.scout.rt.testing.commons.ScoutAssert
import org.eclipse.scout.rt.testing.commons.OsUtility;

2. Add a dependency to org.eclipse.scout.rt.testing.commons where it is missing.
Comment 5 Ken Lee CLA 2013-03-05 06:25:21 EST 
I added the new plugin org.eclipse.scout.testing.commons to the CBI build with commit 00303b1ee21012680f445304c7fa3cb87a3e6a6c.
Comment 6 Ken Lee CLA 2013-03-05 06:26:53 EST 
Please verify the changes.
Comment 7 Jeremie Bresson CLA 2013-03-07 06:57:05 EST 
fixed by ken
Comment 8 Jeremie Bresson CLA 2013-03-07 07:49:37 EST 
Verified.
Comment 9 Jeremie Bresson CLA 2013-03-18 08:48:30 EDT 
We should do the migration changes (described in comment #4) in the testing plugins:

org.eclipse.scout.testing.client.runner.ScoutClientJobWrapperStatement
org.eclipse.scout.testing.client.AbstractTestWithGuiScript
org.eclipse.scout.rt.testing.server.runner.ScoutServerJobWrapperStatement

Should I open a new bug, or push the changes in the 3 mentioned classes as part of this bug?
Comment 10 Judith Gull CLA 2013-03-18 10:36:49 EDT 
Migration in the scout code almost comes with moving the classes. -> This can be done as part of this bug.
Comment 11 Jeremie Bresson CLA 2013-03-18 11:02:34 EDT 
OK thanks,

Because I am not able to verify the maven build (somehow broken because "Not authorized, ReasonPhrase:Unauthorized"), I pushed the commit on a branch on GitHub:
https://github.com/BSI-Business-Systems-Integration-AG/scout.rt/tree/bug400541

Can someone verify the change, rebase it on master and push it to eclipse repository?
Comment 12 Jeremie Bresson CLA 2013-03-23 08:21:42 EDT 
Changes described in comment comment #9 have been pushed with commit: e8421773aedf1ade7652be12a2ebfb3184783b59 for M7.
Comment 13 Matthias Zimmermann CLA 2013-07-08 17:26:49 EDT 
Bug closed, shipped with 3.9.0 (Kepler)